svn commit: r332200 - stable/11/sys/netinet

Michael Tuexen tuexen at FreeBSD.org
Sat Apr 7 19:13:06 UTC 2018


Author: tuexen
Date: Sat Apr  7 19:13:05 2018
New Revision: 332200
URL: https://svnweb.freebsd.org/changeset/base/332200

Log:
  MFC r323850:
  
  Free the control structure after using is, not before.
  Found by Coverity while scanning the usrsctp library.

Modified:
  stable/11/sys/netinet/sctp_indata.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/netinet/sctp_indata.c
==============================================================================
--- stable/11/sys/netinet/sctp_indata.c	Sat Apr  7 19:11:21 2018	(r332199)
+++ stable/11/sys/netinet/sctp_indata.c	Sat Apr  7 19:13:05 2018	(r332200)
@@ -1379,10 +1379,10 @@ sctp_queue_data_for_reasm(struct sctp_tcb *stcb, struc
 		}
 		if (sctp_place_control_in_stream(strm, asoc, control)) {
 			/* Duplicate SSN? */
-			sctp_clean_up_control(stcb, control);
 			sctp_abort_in_reasm(stcb, control, chk,
 			    abort_flag,
 			    SCTP_FROM_SCTP_INDATA + SCTP_LOC_6);
+			sctp_clean_up_control(stcb, control);
 			return;
 		}
 		if ((tsn == (asoc->cumulative_tsn + 1) && (asoc->idata_supported == 0))) {


More information about the svn-src-all mailing list