svn commit: r324049 - head/sys/dev/hyperv/netvsc

[Sepherosa Ziehau]

Thanks, I am doing a test building.  I am planning to drop the Hyper-V
on i386, which is never officially supported.

On Thu, Sep 28, 2017 at 2:08 PM, Cy Schubert <Cy.Schubert at komquats.com> wrote:
> In message <201709270544.v8R5io50067311 at repo.freebsd.org>, Sepherosa Ziehau
> wri
> tes:
>> Author: sephe
>> Date: Wed Sep 27 05:44:50 2017
>> New Revision: 324049
>> URL: https://svnweb.freebsd.org/changeset/base/324049
>>
>> Log:
>>   hyperv/hn: Fix UDP checksum offload issue in Azure.
>>
>>   UDP checksum offload does not work in Azure if following conditions are
>>   met:
>>   - sizeof(IP hdr + UDP hdr + payload) > 1420.
>>   - IP_DF is not set in IP hdr
>>
>>   Use software checksum for UDP datagrams falling into this category.
>>
>>   Add two tunables to disable UDP/IPv4 and UDP/IPv6 checksum offload, in
>>   case something unexpected happened.
>>
>>   MFC after:  1 week
>>   Sponsored by:       Microsoft
>>   Differential Revision:      https://reviews.freebsd.org/D12429
>>
>> Modified:
>>   head/sys/dev/hyperv/netvsc/if_hn.c
>>
>> Modified: head/sys/dev/hyperv/netvsc/if_hn.c
>> =============================================================================
>> =
>> --- head/sys/dev/hyperv/netvsc/if_hn.c        Wed Sep 27 04:42:40 2017
>>       (r324048)
>> +++ head/sys/dev/hyperv/netvsc/if_hn.c        Wed Sep 27 05:44:50 2017
>>       (r324049)
>> @@ -62,6 +62,7 @@ __FBSDID("$FreeBSD$");
>>
>>  #include <sys/param.h>
>>  #include <sys/bus.h>
>> +#include <sys/counter.h>
>
> Shouldn't this go after the #include <sys/systm.h> ?
>
> Found in tinderbox:
>
> i386 GENERIC-NODEBUG kernel failed, check _.i386.GENERIC-NODEBUG for details
>
> In _.i386.GENERIC-NODEBUG:
>
> In file included from /home/cy/current/sys/dev/hyperv/netvsc/if_hn.c:65:
> In file included from /home/cy/current/sys/sys/counter.h:35:
> ./machine/counter.h:172:3: error: implicit declaration of function
> 'critical_ent
> er' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
>                 critical_enter();
>                 ^
> WARNING: ctfconvert: enum pmc_event has too many values: 2629 > 1023
> ./machine/counter.h:172:3: error: this function declaration is not a
> prototype [
> -Werror,-Wstrict-prototypes]
> ./machine/counter.h:174:3: error: implicit declaration of function
> 'critical_exi
> t' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
>                 critical_exit();
>
>
>>  #include <sys/kernel.h>
>>  #include <sys/limits.h>
>>  #include <sys/malloc.h>
>
>
>
> --
> Cheers,
> Cy Schubert <Cy.Schubert at cschubert.com>
> FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org
>
>         The need of the many outweighs the greed of the few.
>
>
>



-- 
Tomorrow Will Never Die