svn commit: r323692 - in head/sys/compat: linsysfs linux

Hans Petter Selasky hps at selasky.org
Mon Sep 18 15:14:31 UTC 2017


On 09/18/17 01:40, Conrad Meyer wrote:
> +
> +		dinfo = device_get_ivars(parent);
> +		if (dinfo != NULL && dinfo->cfg.baseclass == PCIC_DISPLAY) {
> +			devclass = device_get_devclass(dev);
> +			if (devclass != NULL)
> +				name = devclass_get_name(devclass);
> +			if (name != NULL && strcmp(name, DRMN_DEV) == 0 &&
> +			    device_get_unit(dev) >= 0) {
> +				sprintf(chardevname, "226:%d",

Order of comparison should be switched.

First check devclass and name.

Then try to access ivars. Else the ivars might have an undefined type!

--HPS


More information about the svn-src-all mailing list