svn commit: r323516 - in head/sys: dev/bnxt dev/e1000 kern net sys
Scott Long
scottl at samsco.org
Fri Sep 15 21:31:13 UTC 2017
> On Sep 13, 2017, at 9:12 AM, Sean Bruno <sbruno at freebsd.org> wrote:
>
>>>> #blamebruno
>>>>
>>>> Reviewed by: sbruno
>>>> Approved by: sbruno (mentor)
>>>> Sponsored by: Limelight Networks
>>>> Differential Revision: https://reviews.freebsd.org/D12235
>>>
>>> *gasps at the LoC count and number of changed drivers*
>>>
>>> Could someone please better break this up in the future..?
>>
>> Agreed. Down the road parsing out individual commits in this jumbo commit
>> will be difficult to parse. IMO this may as well have simply been, import
>> from https://github.com/mattmacy/networking/, just like Mr. Torvalds does
>> at kernel.org. I expect to see a commit like this there but not here. Can
>> we break this down to its functional commits?
>>
>>
>
>
> This ridiculous loc was due to the amount of restructuring needed to get
> us back to being in sync with our development. The future will not have
> this big of a commit/change and should be more bite/fun sized.
>
> The #blamebruno tag in the commit log was to indicate that this was not
> something Stephen was doing on his own, but was something that I had
> induced over the last few months during testing.
>
This breaks my system. I prior to this commit, I had igb0 and igb1. Now I
only have igb0, and it’s like igb1 isn’t even trying to attach. Unfortunately,
this breaks my nfsroot setup, so I need to roll back my tree. Please let me
know if there’s anything I can provide to help debugging.
Scott
More information about the svn-src-all
mailing list