svn commit: r323393 - in head/sys: sys vm

Gleb Smirnoff glebius at FreeBSD.org
Wed Sep 13 22:42:34 UTC 2017


On Mon, Sep 11, 2017 at 09:30:10AM +0200, Mateusz Guzik wrote:
M> First, there is a bunch of counter(9) fields. I don't know the original
M> reasoning. I would expect these counters to be statically defined in a
M> per-cpu struct.

The reasoning was to remove 'struct vmmeter' from the 'struct pcpu', which
sounds inline with your desire to remote struct vmmeter from the kernel
at all.

Maintainance wise, it is much easier not to bloat 'struct pcpu' with
various global statistics, but keep them as counter(9)s instead. Indeed,
what's the big difference between TCP statistics and VM statistics, why
treat them differently?

Performance wise, I haven't seen any regressions when collapsed
multiple entities of struct vmmeter sitting in struct pcpu, into
single one with counter(9)s.

-- 
Gleb Smirnoff


More information about the svn-src-all mailing list