svn commit: r323516 - in head/sys: dev/bnxt dev/e1000 kern net sys

[Cy Schubert]

In message <48654d1f-4cc7-da05-7a73-ef538b431560 at freebsd.org>, Sean Bruno 
write
s:
> This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
> --K3RXSO7fXoxBXqJUE1dpQ1sEQkuJPg1DQ
> Content-Type: multipart/mixed; boundary="lalB5jI6dIhQxjTp1UFWH9Jx4OpW69Pfe";
>  protected-headers="v1"
> From: Sean Bruno <sbruno at freebsd.org>
> To: Cy Schubert <Cy.Schubert at komquats.com>,
>  Ngie Cooper <yaneurabeya at gmail.com>
> Cc: Stephen Hurd <shurd at FreeBSD.org>, src-committers at freebsd.org,
>  svn-src-all at freebsd.org, svn-src-head at freebsd.org
> Message-ID: <48654d1f-4cc7-da05-7a73-ef538b431560 at freebsd.org>
> Subject: Re: svn commit: r323516 - in head/sys: dev/bnxt dev/e1000 kern net
>  sys
> References: <201709130711.v8D7BlTS003204 at slippy.cwsent.com>
> In-Reply-To: <201709130711.v8D7BlTS003204 at slippy.cwsent.com>
> 
> --lalB5jI6dIhQxjTp1UFWH9Jx4OpW69Pfe
> Content-Type: text/plain; charset=utf-8
> Content-Language: en-US
> Content-Transfer-Encoding: quoted-printable
> 
> >>>  #blamebruno
> >>>
> >>>  Reviewed by:    sbruno
> >>>  Approved by:    sbruno (mentor)
> >>>  Sponsored by:    Limelight Networks
> >>>  Differential Revision:    https://reviews.freebsd.org/D12235
> >>
> >> *gasps at the LoC count and number of changed drivers*
> >>
> >> Could someone please better break this up in the future..?
> >=20
> > Agreed. Down the road parsing out individual commits in this jumbo comm=
> it=20
> > will be difficult to parse. IMO this may as well have simply been, impo=
> rt=20
> > from https://github.com/mattmacy/networking/, just like Mr. Torvalds do=
> es=20
> > at kernel.org. I expect to see a commit like this there but not here. C=
> an=20
> > we break this down to its functional commits?
> >=20
> >=20
> 
> 
> This ridiculous loc was due to the amount of restructuring needed to get
> us back to being in sync with our development.  The future will not have
> this big of a commit/change and should be more bite/fun sized.
> 
> The #blamebruno tag in the commit log was to indicate that this was not
> something Stephen was doing on his own, but was something that I had
> induced over the last few months during testing.

I suppose it is sometimes unavoidable.


-- 
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.