svn commit: r323189 - stable/10/lib/libcompiler_rt

Dimitry Andric dim at FreeBSD.org
Tue Sep 5 17:32:17 UTC 2017


Author: dim
Date: Tue Sep  5 17:32:14 2017
New Revision: 323189
URL: https://svnweb.freebsd.org/changeset/base/323189

Log:
  MFC r323001:
  
  In compiler-rt, a few assembler implementations for i386 floating point
  conversion functions use SSE2 instructions, but these are not guarded by
  #ifdef __SSE2__, and there is no implementation using general purpose
  registers.  For these functions, use the generic C variants instead,
  otherwise they will cause SIGILL on older processors.
  
  Approved by:	re (kib)
  Reported by:	bsdpr at phoe.frmug.org
  PR:		221733
  
  MFC r323014:
  
  Follow-up to r323001: if the actually selected CPUTYPE is capable of
  SSE2 instructions, we can use them.
  
  Suggested by:	jkim
  PR:		221733

Modified:
  stable/10/lib/libcompiler_rt/Makefile
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/lib/libcompiler_rt/Makefile
==============================================================================
--- stable/10/lib/libcompiler_rt/Makefile	Tue Sep  5 17:12:12 2017	(r323188)
+++ stable/10/lib/libcompiler_rt/Makefile	Tue Sep  5 17:32:14 2017	(r323189)
@@ -65,15 +65,9 @@ SRCF=	absvdi2 \
 	fixunsxfti \
 	fixxfdi \
 	fixxfti \
-	floatdidf \
-	floatdisf \
-	floatdixf \
 	floattidf \
 	floattisf \
 	floattixf \
-	floatundidf \
-	floatundisf \
-	floatundixf \
 	floatunsidf \
 	floatunsisf \
 	floatuntidf \
@@ -125,6 +119,23 @@ SRCF=	absvdi2 \
 	udivti3 \
 	umoddi3 \
 	umodti3
+
+# Avoid using SSE2 instructions on i386, if unsupported.
+.if ${MACHINE_CPUARCH} == "i386" && empty(MACHINE_CPU:Msse2)
+SRCS+=		floatdidf.c
+SRCS+=		floatdisf.c
+SRCS+=		floatdixf.c
+SRCS+=		floatundidf.c
+SRCS+=		floatundisf.c
+SRCS+=		floatundixf.c
+.else
+SRCF+=		floatdidf
+SRCF+=		floatdisf
+SRCF+=		floatdixf
+SRCF+=		floatundidf
+SRCF+=		floatundisf
+SRCF+=		floatundixf
+.endif
 
 # These are already shipped by libc.a on arm and mips
 .if ${MACHINE_CPUARCH} != "arm" && ${MACHINE_CPUARCH} != "mips"


More information about the svn-src-all mailing list