svn commit: r325040 - head/sys/cam/nvme

[Warner Losh]

On Fri, Oct 27, 2017 at 9:05 AM, Alan Somers <asomers at freebsd.org> wrote:

> On Fri, Oct 27, 2017 at 8:57 AM, Warner Losh <imp at freebsd.org> wrote:
> > Author: imp
> > Date: Fri Oct 27 14:57:38 2017
> > New Revision: 325040
> > URL: https://svnweb.freebsd.org/changeset/base/325040
> >
> > Log:
> >   nvd alias has caused some problems, revert it for the moment.
> >
> >   Sponsored by: Netflix
> >
> > Modified:
> >   head/sys/cam/nvme/nvme_da.c
> >
> > Modified: head/sys/cam/nvme/nvme_da.c
> > ============================================================
> ==================
> > --- head/sys/cam/nvme/nvme_da.c Fri Oct 27 14:57:14 2017        (r325039)
> > +++ head/sys/cam/nvme/nvme_da.c Fri Oct 27 14:57:38 2017        (r325040)
> > @@ -794,7 +794,7 @@ ndaregister(struct cam_periph *periph, void *arg)
> >         /*
> >          * Add alias for older nvd drives to ease transition.
> >          */
> > -       disk_add_alias(disk, "nvd");
> > +       /* disk_add_alias(disk, "nvd"); Have reports of this causing
> problems */
> >
> >         /*
> >          * Acquire a reference to the periph before we register with
> GEOM.
>
> Is there a PR?  If so, please link the PR from the comment.
>

No PR. We had a problem at Netflix with the multiple drives we have in a
system, so we disabled it locally. I wasn't seeing it in !Netflix FreeBSD
at the time, so I didn't upstream. I since discovered the problem on a raw
FreeBSD kernel on my machines here, but haven't had time to investigate
further. It could be multiple drives, or something else triggering it. I
just don't know yet, so there's nothing concrete to point to.

Warner