svn commit: r324950 - head/libexec/rtld-elf
Edward Tomasz Napierala
trasz at FreeBSD.org
Tue Oct 24 11:16:39 UTC 2017
Author: trasz
Date: Tue Oct 24 11:16:38 2017
New Revision: 324950
URL: https://svnweb.freebsd.org/changeset/base/324950
Log:
Reword the conditional; it was ugly, and adding another parameter,
which I'm going to do in a subsequent commit, would make it even uglier.
No functional changes.
MFC after: 2 weeks
Sponsored by: DARPA, AFRL
Modified:
head/libexec/rtld-elf/rtld.c
Modified: head/libexec/rtld-elf/rtld.c
==============================================================================
--- head/libexec/rtld-elf/rtld.c Tue Oct 24 10:48:26 2017 (r324949)
+++ head/libexec/rtld-elf/rtld.c Tue Oct 24 11:16:38 2017 (r324950)
@@ -1620,27 +1620,54 @@ find_library(const char *xname, const Obj_Entry *refob
* nodeflib.
*/
if (objgiven && refobj->rpath != NULL && ld_library_path_rpath) {
- if ((pathname = search_library_path(name, ld_library_path)) != NULL ||
- (refobj != NULL &&
- (pathname = search_library_path(name, refobj->rpath)) != NULL) ||
- (pathname = search_library_pathfds(name, ld_library_dirs, fdp)) != NULL ||
- (pathname = search_library_path(name, gethints(false))) != NULL ||
- (pathname = search_library_path(name, ld_standard_library_path)) != NULL)
+ pathname = search_library_path(name, ld_library_path);
+ if (pathname != NULL)
return (pathname);
+ if (refobj != NULL) {
+ pathname = search_library_path(name, refobj->rpath);
+ if (pathname != NULL)
+ return (pathname);
+ }
+ pathname = search_library_pathfds(name, ld_library_dirs, fdp);
+ if (pathname != NULL)
+ return (pathname);
+ pathname = search_library_path(name, gethints(false));
+ if (pathname != NULL)
+ return (pathname);
+ pathname = search_library_path(name, ld_standard_library_path);
+ if (pathname != NULL)
+ return (pathname);
} else {
nodeflib = objgiven ? refobj->z_nodeflib : false;
- if ((objgiven &&
- (pathname = search_library_path(name, refobj->rpath)) != NULL) ||
- (objgiven && refobj->runpath == NULL && refobj != obj_main &&
- (pathname = search_library_path(name, obj_main->rpath)) != NULL) ||
- (pathname = search_library_path(name, ld_library_path)) != NULL ||
- (objgiven &&
- (pathname = search_library_path(name, refobj->runpath)) != NULL) ||
- (pathname = search_library_pathfds(name, ld_library_dirs, fdp)) != NULL ||
- (pathname = search_library_path(name, gethints(nodeflib))) != NULL ||
- (objgiven && !nodeflib &&
- (pathname = search_library_path(name, ld_standard_library_path)) != NULL))
+ if (objgiven) {
+ pathname = search_library_path(name, refobj->rpath);
+ if (pathname != NULL)
+ return (pathname);
+ }
+ if (objgiven && refobj->runpath == NULL && refobj != obj_main) {
+ pathname = search_library_path(name, obj_main->rpath);
+ if (pathname != NULL)
+ return (pathname);
+ }
+ pathname = search_library_path(name, ld_library_path);
+ if (pathname != NULL)
return (pathname);
+ if (objgiven) {
+ pathname = search_library_path(name, refobj->runpath);
+ if (pathname != NULL)
+ return (pathname);
+ }
+ pathname = search_library_pathfds(name, ld_library_dirs, fdp);
+ if (pathname != NULL)
+ return (pathname);
+ pathname = search_library_path(name, gethints(nodeflib));
+ if (pathname != NULL)
+ return (pathname);
+ if (objgiven && !nodeflib) {
+ pathname = search_library_path(name, ld_standard_library_path);
+ if (pathname != NULL)
+ return (pathname);
+ }
}
if (objgiven && refobj->path != NULL) {
More information about the svn-src-all
mailing list