svn commit: r324911 - head/share/mk

[Warner Losh]

On Mon, Oct 23, 2017 at 7:09 AM, Justin Hibbits <chmeeedalf at gmail.com>
wrote:

> On Oct 23, 2017 07:57, "Ngie Cooper" <yaneurabeya at gmail.com> wrote:
>
>
> > On Oct 23, 2017, at 01:48, Konstantin Belousov <kostikbel at gmail.com>
> wrote:
> >
> >> On Mon, Oct 23, 2017 at 07:56:56AM +0000, Ngie Cooper wrote:
> >> Author: ngie
> >> Date: Mon Oct 23 07:56:56 2017
> >> New Revision: 324911
> >> URL: https://svnweb.freebsd.org/changeset/base/324911
> >>
> >> Log:
> >>  Fix an omission in a comment
> >>
> >>  Soft float API support applies to armv7 too after r324340
> > Does it ?  From my understanding, requiring hw float was one of the
> > reason for armv7 appearance.
>
> Hah... the comment’s backwards. Classic!
>
>
> It was my understanding that armv{6,7} use the softfloat ABI but still
> require a hardware float.
>

No. Thats not true in FreeBSD 11 and newer. Hard float with hard float ABI
is the default, although we can compile armv7 with soft floating point ABI
using either software fp or hardware fp. These libraries are meant to
bridge the gap between the two worlds, though the armv7 stuff is largely
untested.

The comment isn't backwards at all. We only do LIBSOFT on amrv6/7. That's
why we mark it 'BROKEN' on the other architectures so we don't try it at
all. Though mips is a good candidate for it.

Warner


> - Justin
>
>
> >>
> >> Modified:
> >>  head/share/mk/src.opts.mk
> >>
> >> Modified: head/share/mk/src.opts.mk
> >> ============================================================
> ==================
> >> --- head/share/mk/src.opts.mk    Mon Oct 23 07:52:16 2017    (r324910)
> >> +++ head/share/mk/src.opts.mk    Mon Oct 23 07:56:56 2017    (r324911)
> >> @@ -271,7 +271,7 @@ __DEFAULT_NO_OPTIONS+=GDB_LIBEXEC
> >> .else
> >> __DEFAULT_YES_OPTIONS+=GDB_LIBEXEC
> >> .endif
> >> -# Only doing soft float API stuff on armv6
> >> +# Only doing soft float API stuff on armv6 and armv7
> >> .if ${__T} != "armv6" && ${__T} != "armv7"
> >> BROKEN_OPTIONS+=LIBSOFT
> >> .endif
>
>
>