svn commit: r324360 - in head/sys/boot/efi: include libefi loader

Ngie Cooper (yaneurabeya) yaneurabeya at gmail.com
Sat Oct 7 17:41:21 UTC 2017


> On Oct 7, 2017, at 09:29, Guy Yur <guyyur at gmail.com> wrote:
> 
> On 6 October 2017 at 15:21, Warner Losh <imp at freebsd.org> wrote:
>> Author: imp
>> Date: Fri Oct  6 12:21:46 2017
>> New Revision: 324360
>> URL: https://svnweb.freebsd.org/changeset/base/324360
>> 
>> Log:
>>  Encapsulate  ZFS preferences into efi_zfs_is_preferred
>> 
>>  Move the retrieval of the image information into loader's main instead
>>  of doing it in efizfs.c
>> 
>>  Differential Revision: https://reviews.freebsd.org/D12564
>>  Submitted by: Eric McCorkle
>> 
>> Modified:
>>  head/sys/boot/efi/include/efizfs.h
>>  head/sys/boot/efi/libefi/efizfs.c
>>  head/sys/boot/efi/loader/main.c
>> 
>> ...
> 
> Hi,
> 
> When setting WITHOUT_ZFS in src.conf the build fails with:
> 
> /usr/src/sys/boot/efi/loader/main.c:78:1: error: no previous prototype
> for function 'efi_zfs_is_preferred'
>      [-Werror,-Wmissing-prototypes]
> efi_zfs_is_preferred(EFI_HANDLE *h)
> ^
> 1 error generated.
> *** Error code 1
> 
> 
> The prototype is under #ifdef EFI_ZFS_BOOT guard but the function is not.

Fixed: r324388.
Thanks!
-Ngie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20171007/f2ea8120/attachment.sig>


More information about the svn-src-all mailing list