svn commit: r326109 - in head/sys: conf dev/bhnd dev/bhnd/cores/chipc mips/conf modules/bhnd

[Shawn Webb]

On Fri, Nov 24, 2017 at 10:21:17AM +0100, Wojciech Macek wrote:
> Hi,
> 
> The patch breaks the build for ppc64. Could you please add missing
> ofw_bus_if.h to the Makefile?
> 
> cc -isystem
> /home/wma/ppc64-freebsd/obj/home/wma/ppc64-freebsd/powerpc.powerpc64/tmp/usr/include
> -L/home/wma/ppc64-freebsd/obj/home/wma/ppc64-freebsd/powerpc.powerpc64/tmp/usr/lib
> -B/home/wma/ppc64-freebsd/obj/home/wma/ppc64-freebsd/powerpc.powerpc64/tmp/usr/lib
> --sysroot=/home/wma/ppc64-freebsd/obj/home/wma/ppc64-freebsd/powerpc.powerpc64/tmp
> -B/home/wma/ppc64-freebsd/obj/home/wma/ppc64-freebsd/powerpc.powerpc64/tmp/usr/bin
> -O2 -pipe  -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc
>  -DHAVE_KERNEL_OPTION_HEADERS -include
> /home/wma/ppc64-freebsd/obj/home/wma/ppc64-freebsd/powerpc.powerpc64/sys/GENERIC64/opt_global.h
> -I. -I/home/wma/ppc64-freebsd/sys -fno-common -g -mlongcall
> -fno-omit-frame-pointer
> -I/home/wma/ppc64-freebsd/obj/home/wma/ppc64-freebsd/powerpc.powerpc64/sys/GENERIC64
>  -MD  -MF.depend.chipc_gpio.o -MTchipc_gpio.o -mno-altivec -ffreestanding
> -fwrapv -fstack-protector -gdwarf-2 -Wall -Wredundant-decls
> -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith
> -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions
> -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas
> -Wno-uninitialized  -finline-limit=15000 -fms-extensions --param
> inline-unit-growth=100 --param large-function-growth=1000 -msoft-float
> -mcall-aixdesc  -std=iso9899:1999 -c
> /home/wma/ppc64-freebsd/sys/dev/bhnd/cores/chipc/chipc_gpio.c -o
> chipc_gpio.o
> In file included from /home/wma/ppc64-freebsd/sys/dev/gpio/gpiobusvar.h:40,
>                  from
> /home/wma/ppc64-freebsd/sys/dev/bhnd/cores/chipc/chipc_gpio.c:48:
> /home/wma/ppc64-freebsd/sys/dev/ofw/ofw_bus_subr.h:40:24: error:
> ofw_bus_if.h: No such file or directory
> cc1: warnings being treated as errors
> In file included from /home/wma/ppc64-freebsd/sys/dev/gpio/gpiobusvar.h:40,
>                  from
> /home/wma/ppc64-freebsd/sys/dev/bhnd/cores/chipc/chipc_gpio.c:48:
> /home/wma/ppc64-freebsd/sys/dev/ofw/ofw_bus_subr.h:71: warning: 'struct
> ofw_bus_devinfo' declared inside parameter list
> /home/wma/ppc64-freebsd/sys/dev/ofw/ofw_bus_subr.h:71: warning: its scope
> is only this definition or declaration, which is probably not what you want
> /home/wma/ppc64-freebsd/sys/dev/ofw/ofw_bus_subr.h:72: warning: 'struct
> ofw_bus_devinfo' declared inside parameter list
> /home/wma/ppc64-freebsd/sys/dev/ofw/ofw_bus_subr.h:74: error: expected '=',
> ',', ';', 'asm' or '__attribute__' before 'ofw_bus_gen_get_compat'
> /home/wma/ppc64-freebsd/sys/dev/ofw/ofw_bus_subr.h:75: error: expected '=',
> ',', ';', 'asm' or '__attribute__' before 'ofw_bus_gen_get_model'
> /home/wma/ppc64-freebsd/sys/dev/ofw/ofw_bus_subr.h:76: error: expected '=',
> ',', ';', 'asm' or '__attribute__' before 'ofw_bus_gen_get_name'
> /home/wma/ppc64-freebsd/sys/dev/ofw/ofw_bus_subr.h:77: error: expected '=',
> ',', ';', 'asm' or '__attribute__' before 'ofw_bus_gen_get_node'
> /home/wma/ppc64-freebsd/sys/dev/ofw/ofw_bus_subr.h:78: error: expected '=',
> ',', ';', 'asm' or '__attribute__' before 'ofw_bus_gen_get_type'
> In file included from
> /home/wma/ppc64-freebsd/sys/dev/bhnd/cores/chipc/chipc_gpio.c:48:
> /home/wma/ppc64-freebsd/sys/dev/gpio/gpiobusvar.h:115: error: field
> 'opd_obdinfo' has incomplete type
> *** [chipc_gpio.o] Error code 1
> 
> make[4]: stopped in /home/wma/ppc64-freebsd/sys/modules/bhnd
> --- all_subdir_cardbus ---
> --- cardbus.o ---
> ctfconvert -L VERSION -g cardbus.o
> A failure has been detected in another branch of the parallel make

We've noticed this in our nightly build system as well. We've
implemented a fix here:

https://github.com/HardenedBSD/hardenedBSD/commit/76b37deb3a5f2c3aa014efadd4e78d748148b884

Thanks,

-- 
Shawn Webb
Cofounder and Security Engineer
HardenedBSD

GPG Key ID:          0x6A84658F52456EEE
GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89  3D9E 6A84 658F 5245 6EEE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20171124/21029ff2/attachment-0001.sig>