svn commit: r325988 - head/sys/libkern

[Warner Losh]

On Nov 20, 2017 9:57 AM, "Ed Maste" <emaste at freebsd.org> wrote:

Hi Bruce, notes on a few of the points you raised (I'll look at others
later):

On 19 November 2017 at 04:07, Bruce Evans <brde at optusnet.com.au> wrote:
>
> The vendor version is in libc/string.  It has been ANSIfied, but the
> libkern version has large churning to "optimize" it.  It is the libkern
> version that should have been optimized, since bcmp is unimportant in
> the kernel and in most applications, but applications have a wider range
> so a few might benefit from optimizing it.

I presume you meant "it is the _libc_ version that should have been
optimized", but could also read this as a distinction between
optimized and scare-quotes "optimized."

> bcmp is actually optimized
> in the kernel in support.[sS] for all arches except powerpc and riscv,
> so optimizing the kernel MI version of it is especially unimportant.
> In libc where MD optimizations are more important, they are also not
> done for arm, arm64 and sparc64.

This could make a nice small project for someone to take on.

> - libc version copyright comment not marked for indent protection using
>   "/*-" (this has been subverted to have another meaning which I forget).

I don't believe there's another meaning. IIRC imp@ has pointed out
that it means precisely what you've mentioned above.


All our copyright notices are marked for protection from indent. I made
that change. It was so that we could filter out all the extra junk quickly
in the conformance scripts people were writing. And these things should be
protected from indent too.

Warner

>> Modified: head/sys/libkern/cmpdi2.c
>> Modified: head/sys/libkern/divdi3.c
>> Modified: head/sys/libkern/lshrdi3.c
>
> Like ashrdi3.c (not ANSIfied in libc/quad).

Ok, I will update libc/quad to match.

> The above declaration was already correctly ANSIfied in libc/gmon.  This
> unimproves the style by keeping the comment misplaced at the right of the
> code where it is a larger style bug than before -- not the line is too
long.
> ANSIfication in libc/gmon put it on a separate line.

Will update the comment along with other mcount tidying.

>> Modified: head/sys/libkern/strcmp.c
>
> The vendor version is in libc/string.  It has been ANSIfied, but the
commit
> that did that also made another style fix.  This change catches up with
half
> of the older change.

Will update.