svn commit: r316980 - head/contrib/zstd/programs

[Conrad Meyer]

On Fri, Nov 17, 2017 at 1:34 AM, Baptiste Daroussin <bapt at freebsd.org> wrote:
> On Wed, Nov 15, 2017 at 07:38:13PM -0800, Conrad Meyer wrote:
>> Please revert this change.
>>
>> First, it introduces the POLA-violating behavior that zstdcat deletes
>> its source files.  This is not how zcat/bzcat behaves.
>
> I have modified zstdcat to behave like zcat/bzcat.
>
> The commit you stated is exactly to ensure the zstd(1) command is behaving like
> xz, gzip, etc (to the exception of zstdcat which was buggy) this commit is
> needed to have those tools a drop-in replacement for other compression programs.
> (which is necessary for example to have newsyslog being able to use zstd.)
>
> I committed a change needed in base and I will start a discussion with upstream
>
> Best regards,
> Bapt

Hi Bapt,

I don't think that's a good enough reason to differ from upstream.
Furthermore, the change isn't documented.

For compatibility with gzip/xz, you could simply add a new
FreeBSD-specific zstd frontend with the behavior you want — instead of
changing every other frontend.  That way the behavior and
documentation would match both the documentation we ship and the
upstream documentation and behavior.  No surprises for anyone.

I really want to emphasize that *deleting user files when we claim we
will not* is an awful design choice to make.  I think this change
should be reverted until at minimum our documentation is updated to
inform users we do not --keep by default.

(I think we should stay with upstream regardless, but if we're going
to make a major change like this it MUST be documented.)

Best,
Conrad