svn commit: r316980 - head/contrib/zstd/programs

[Baptiste Daroussin]

On Wed, Nov 15, 2017 at 07:38:13PM -0800, Conrad Meyer wrote:
> Please revert this change.
> 
> First, it introduces the POLA-violating behavior that zstdcat deletes
> its source files.  This is not how zcat/bzcat behaves.

This is not a POLA-violating behavior, this is a bug! that I introduced.
> 
> Second, it introduces a needless behavioral difference between FreeBSD
> zstd and the rest of the world's zstd.  The zstd documentation we ship
> continues to claim that zstd preserves source files by default, yet
> this change makes that documentation exactly backwards.  While we can
> change FreeBSD's documentation to accommodate the change, we can't
> change Google results.
> 

The difference has been made so that zstd follow by default the same behaviour
has gzip/bzip2/xz so it can be a dropped in replacement.

The argument about the documentation is however a good one. Let me do first some
tests to ensure restoring the initial behaviour does not break existing usage in
base

Best regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20171116/71a90482/attachment.sig>