svn commit: r325625 - head/sys/sys

Conrad Meyer cem at FreeBSD.org
Fri Nov 10 02:00:41 UTC 2017


Author: cem
Date: Fri Nov 10 02:00:40 2017
New Revision: 325625
URL: https://svnweb.freebsd.org/changeset/base/325625

Log:
  systm.h: Include cdefs.h first
  
  Ever since r143063, machine/atomic.h requires cdefs.h.  So, include it
  first.  Weak support: style(9) tells us to include cdefs.h first.
  
  Argument against: since code that includes systm.h still compiles,
  compilation units that include systm.h must already include cdefs.h.  So, an
  argument could be made that the cdefs.h include could just be removed
  entirely.  That is maybe a bigger change and not one I am interested in
  bikeshedding.
  
  Universe compiles.
  
  Sponsored by:	Dell EMC Isilon

Modified:
  head/sys/sys/systm.h

Modified: head/sys/sys/systm.h
==============================================================================
--- head/sys/sys/systm.h	Fri Nov 10 01:17:26 2017	(r325624)
+++ head/sys/sys/systm.h	Fri Nov 10 02:00:40 2017	(r325625)
@@ -38,10 +38,10 @@
 #ifndef _SYS_SYSTM_H_
 #define	_SYS_SYSTM_H_
 
+#include <sys/cdefs.h>
 #include <machine/atomic.h>
 #include <machine/cpufunc.h>
 #include <sys/callout.h>
-#include <sys/cdefs.h>
 #include <sys/queue.h>
 #include <sys/stdint.h>		/* for people using printf mainly */
 


More information about the svn-src-all mailing list