svn commit: r325116 - head

[Ngie Cooper (yaneurabeya)]

> On Nov 4, 2017, at 08:31, Bryan Drewery <bdrewery at FreeBSD.org> wrote:
> 
> On 11/4/2017 12:08 AM, Ngie Cooper (yaneurabeya) wrote:
>> 	I just ran into this with bash on universe12a.freebsd.org by doing ^d. I think the change should be reverted.
>> Thanks,
>> -Ngie
>> 
>> $ exit
>> *** Error code 130
>> 
>> Stop.
>> make[1]: stopped in /scratch/tmp/ngie/svn
>> *** Error code 1
>> 
>> Stop.
>> make: stopped in /scratch/tmp/ngie/svn
>> 
> 
> When you first go into buildenv check 'echo $?'.
> My problem was a construct like '[ -f xxx ] && . xxx' at the end of one
> of my profile scripts.  It needs to be 'if [ -f xxx ]; then . xxx; fi'
> to avoid the bad status.  It's really unrelated to buildenv.

The last line in my ~/.bashrc on my VM is export PATH that doesn’t fail with a syntax error, and the last line on my ~/.bashrc on universe12a is an alias set, which also doesn’t fail with a syntax error. Both cases set $? = 0.

The issue I reported is caused by doing ^c + ^d (hence the error code 130 in my original reply). I guess this is expected, but it’s going to confuse people and force them to have to investigate the issue, unnecessarily, when it wasn’t an “issue” before.

-Ngie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20171104/e1705a22/attachment.sig>