svn commit: r319125 - head/usr.bin/mkimg

Ngie Cooper yaneurabeya at gmail.com
Wed May 31 17:38:54 UTC 2017


> On May 31, 2017, at 02:48, Emmanuel Vadot <manu at bidouilliste.com> wrote:
> 
> On Wed, 31 May 2017 00:20:45 -0700
> "Ngie Cooper (yaneurabeya)" <yaneurabeya at gmail.com> wrote:
> 
>> 
>>> On May 29, 2017, at 05:51, Emmanuel Vadot <manu at FreeBSD.org> wrote:
>>> 
>>> Author: manu
>>> Date: Mon May 29 12:51:02 2017
>>> New Revision: 319125
>>> URL: https://svnweb.freebsd.org/changeset/base/319125
>>> 
>>> Log:
>>> mkimg: Correct an off by one error in the PMBR size
>>> 
>>> The PMBR last sector should be number of sector - 1 (As stated in UEFI Spec
>>> 2.6 page 118 table 17).
>>> This fixes warning printed by linux tools like parted or fdisk.
>> 
>> This commit broke all of the mkimg gpt tests. For example: https://ci.freebsd.org/job/FreeBSD-head-amd64-test/3280/testReport/junit/usr.bin.mkimg/mkimg_test/gpt_1x1_4096_qcow/ .
>> -Ngie
> 
> Sorry about that and thanks for the fix.

    No worries -- it turns out I broke something by accident as well, and I fixed both items at the same time.
Take it easy :),
-Ngie


More information about the svn-src-all mailing list