svn commit: r318814 - head/cddl/contrib/opensolaris/lib/libzfs_core/common

Andriy Gapon avg at FreeBSD.org
Wed May 24 20:53:03 UTC 2017


Author: avg
Date: Wed May 24 20:53:01 2017
New Revision: 318814
URL: https://svnweb.freebsd.org/changeset/base/318814

Log:
  MFC r316904: 7729 libzfs_core`lzc_rollback() leaks result nvl
  
  illumos/illumos-gate at ac428481f96be89add7a1edf43ae47dd71038553
  https://github.com/illumos/illumos-gate/commit/ac428481f96be89add7a1edf43ae47dd71038553
  
  https://www.illumos.org/issues/7729
    libzfs_core`lzc_rollback() doesn't free the result nvl after lzc_ioctl() call.
  
  Reviewed by: Matthew Ahrens <mahrens at delphix.com>
  Reviewed by: Prakash Surya <prakash.surya at delphix.com>
  Approved by: Dan McDonald <danmcd at omniti.com>
  Author: Yuri Pankov <yuri.pankov at nexenta.com>
  
  MFC after:	2 weeks

Modified:
  head/cddl/contrib/opensolaris/lib/libzfs_core/common/libzfs_core.c
Directory Properties:
  head/cddl/contrib/opensolaris/   (props changed)

Modified: head/cddl/contrib/opensolaris/lib/libzfs_core/common/libzfs_core.c
==============================================================================
--- head/cddl/contrib/opensolaris/lib/libzfs_core/common/libzfs_core.c	Wed May 24 20:52:47 2017	(r318813)
+++ head/cddl/contrib/opensolaris/lib/libzfs_core/common/libzfs_core.c	Wed May 24 20:53:01 2017	(r318814)
@@ -759,6 +759,8 @@ lzc_rollback(const char *fsname, char *s
 		const char *snapname = fnvlist_lookup_string(result, "target");
 		(void) strlcpy(snapnamebuf, snapname, snapnamelen);
 	}
+	nvlist_free(result);
+
 	return (err);
 }
 


More information about the svn-src-all mailing list