svn commit: r318166 - head/sys/netinet

[Fabian Keil]

Gleb Smirnoff <glebius at FreeBSD.org> wrote:

> Author: glebius
> Date: Wed May 10 23:32:31 2017
> New Revision: 318166
> URL: https://svnweb.freebsd.org/changeset/base/318166
> 
> Log:
>   There is no good reason for TCP reassembly zone to be UMA_ZONE_NOFREE.
>   
>   It has strong locking model, doesn't have any timers associated with
>   entries.  The entries theirselves are referenced only from the tcpcb
> zone, which itself is a normal zone, without the UMA_ZONE_NOFREE flag.

A side effect of the UMA_ZONE_NOFREE flag is that allocations
with M_NOWAIT (currently used tcp_reass()) are less likely to
fail.

Removing the UMA_ZONE_NOFREE in other TCP-related parts
"recently" caused (still unfixed) regressions like:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209680

It would be great if there was a method to reserve a certain
number of items for the zone without having to rely on
UMA_ZONE_NOFREE but last time I checked there wasn't one.

Fabian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20170511/43e94efd/attachment.sig>