svn commit: r310295 - in head/sys: conf dev/bhnd/nvram modules/bhnd

[Ed Maste]

On 19 December 2016 at 15:28, Landon J. Fuller <landonf at freebsd.org> wrote:
> Author: landonf
> Date: Mon Dec 19 20:28:27 2016
> New Revision: 310295
> URL: https://svnweb.freebsd.org/changeset/base/310295
>
> Log:
>   bhnd(4): NVRAM device path support.
>
>   Implements bhnd_nvram_store support for parsing and operating over NVRAM
>   device paths, and device path aliases, as well as tracking per-path NVRAM
>   variable writes.

> @@ -871,13 +881,45 @@ bhnd_nvram_sprom_getvar(struct bhnd_nvra
>        if ((var->flags & BHND_NVRAM_VF_IGNALL1) && all_bits_set)
>                return (ENOENT);
>
> +       /* Provide value wrapper */
> +       return (bhnd_nvram_val_init(val, var->fmt, inp, ilen, var->type,
> +           BHND_NVRAM_VAL_BORROW_DATA));
> +               return (error);
> +}

The extra return here seems odd; Coverity picked it up as CID 1373118.