svn commit: r315662 - in head: contrib/bsnmp/snmp_mibII contrib/ipfilter/ipsend lib/libprocstat sys/netinet sys/sys usr.bin/netstat usr.bin/sockstat usr.bin/systat usr.sbin/tcpdrop usr.sbin/trpt

Gleb Smirnoff glebius at FreeBSD.org
Tue Mar 21 20:40:24 UTC 2017


On Tue, Mar 21, 2017 at 10:52:02PM +0300, Slawa Olhovchenkov wrote:
S> > On Tue, Mar 21, 2017 at 10:40:34AM -0700, John Baldwin wrote:
S> > J> First, this is a very good change and long overdue in divorcing the
S> > J> user-facing structure for live system reporting vs the kernel structure.
S> > J> 
S> > J> However, I realize you don't use info from netstat when debugging kernel
S> > J> crash dumps, but other people _do_.  It's ok if the kvm bits of netstat
S> > J> require a matching kernel and thus require recompiling everytime the ABI
S> > J> changes, but it is useful to have them.  Please restore those.
S> > 
S> > I have very much anticipated this comment from you, John.
S> > 
S> > I would like to remind you, that we have had this very exact conversation
S> > back when I removed kvm support from netstat/route.c. Let me search the
S> > archives:
S> > 
S> > https://lists.freebsd.org/pipermail/svn-src-head/2015-April/070480.html
S> > 
S> > This conversation has had a continuation on IRC, which I don't archive.
S> > 
S> > AFAIR, first I told that with all my involvement into networking stack,
S> > I never ever had experienced a need to run route stats on a core. The
S> > debugger were the only useful tool. And that opinion was seconded by
S> > other network hackers. Then we discussed that a proper tool chould use
S> > dynamic type parsing and not kvm(3). You said that future gdb has python
S> > scripting and that would work fine. Meanwhile, you insisted that I restore
S> > the functionality. I resisted to put kvm(3) back into netstat/route.c, and
S> > instead I created a gdb script that prints exactly what 'nestat -anr -M core'
S> > prints. And I committed the script just to satisfy your demand:
S> > 
S> > tools/debugscripts/netstat-anr.gdb
S> > 
S> > Can you please fairly answer, have you (or anyone else) ever used the
S> > script during these 2 years?
S> > 
S> > I believe, the inpcb/tcpcb printing from a core functionality has the
S> > same level of real usefulness. I could create the same script for pcbs,
S> > and I am afraid it is going to share fate of netstat-anr.gdb.
S> 
S> How long run this script for core file w/ 40K TCP connections?

You tell me. When I analyze cores, I don't read through 40K TCP connections.

-- 
Totus tuus, Glebius.


More information about the svn-src-all mailing list