svn commit: r315662 - in head: contrib/bsnmp/snmp_mibII contrib/ipfilter/ipsend lib/libprocstat sys/netinet sys/sys usr.bin/netstat usr.bin/sockstat usr.bin/systat usr.sbin/tcpdrop usr.sbin/trpt

[Antoine Brodin]

On Tue, Mar 21, 2017 at 7:41 AM, Gleb Smirnoff <glebius at freebsd.org> wrote:
>   Hi!
>
>   This change is known to break a ton of ports. More than 100 if
> counting depends. I'm sorry for that and I already started to fix
> them.
>
> Please send all new breakages to me.

Hi,

Exp-runs should happen before breakage happens, not after.
If you already know that it breaks hundreds of ports, please revert
and request an exp-run.

Antoine  (with hat: portmgr)


> On Tue, Mar 21, 2017 at 06:39:49AM +0000, Gleb Smirnoff wrote:
> T> Author: glebius
> T> Date: Tue Mar 21 06:39:49 2017
> T> New Revision: 315662
> T> URL: https://svnweb.freebsd.org/changeset/base/315662
> T>
> T> Log:
> T>   Hide struct inpcb, struct tcpcb from the userland.
> T>
> T>   This is a painful change, but it is needed.  On the one hand, we avoid
> T>   modifying them, and this slows down some ideas, on the other hand we still
> T>   eventually modify them and tools like netstat(1) never work on next version of
> T>   FreeBSD.  We maintain a ton of spares in them, and we already got some ifdef
> T>   hell at the end of tcpcb.
> T>
> T>   Details:
> T>   - Hide struct inpcb, struct tcpcb under _KERNEL || _WANT_FOO.
> T>   - Make struct xinpcb, struct xtcpcb pure API structures, not including
> T>     kernel structures inpcb and tcpcb inside.  Export into these structures
> T>     the fields from inpcb and tcpcb that are known to be used, and put there
> T>     a ton of spare space.
> T>   - Make kernel and userland utilities compilable after these changes.
> T>   - Bump __FreeBSD_version.
> T>
> T>   Reviewed by:       rrs, gnn
> T>   Differential Revision:     D10018