svn commit: r315612 - stable/10/contrib/bsnmp/snmpd

[Ngie Cooper]

Author: ngie
Date: Mon Mar 20 03:13:03 2017
New Revision: 315612
URL: https://svnweb.freebsd.org/changeset/base/315612

Log:
  MFC r315206:
  
  bsnmpd: fix segfault when trans_insert_port(..) is called with multiple
  out of order addresses
  
  Move `port->transport` initialization before the TAILQ_FOREACH(..) loop
  to ensure that the value is properly initialized before it's inserted
  into the TAILQ.
  
  PR:		217760

Modified:
  stable/10/contrib/bsnmp/snmpd/main.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/contrib/bsnmp/snmpd/main.c
==============================================================================
--- stable/10/contrib/bsnmp/snmpd/main.c	Mon Mar 20 03:13:00 2017	(r315611)
+++ stable/10/contrib/bsnmp/snmpd/main.c	Mon Mar 20 03:13:03 2017	(r315612)
@@ -765,13 +765,13 @@ trans_insert_port(struct transport *t, s
 {
 	struct tport *p;
 
+	port->transport = t;
 	TAILQ_FOREACH(p, &t->table, link) {
 		if (asn_compare_oid(&p->index, &port->index) > 0) {
 			TAILQ_INSERT_BEFORE(p, port, link);
 			return;
 		}
 	}
-	port->transport = t;
 	TAILQ_INSERT_TAIL(&t->table, port, link);
 }