svn commit: r315207 - head/sys/netinet/libalias

[Conrad Meyer]

Author: cem
Date: Mon Mar 13 18:05:31 2017
New Revision: 315207
URL: https://svnweb.freebsd.org/changeset/base/315207

Log:
  alias_proxy.c: Fix accidental error quashing
  
  This was introduced on accident in r165243, when return sites were unified
  to add a lock around LibAliasProxyRule().
  
  PR:		217749
  Submitted by:	Svyatoslav <razmyslov at viva64.com>
  Sponsored by:	Viva64 (PVS-Studio)

Modified:
  head/sys/netinet/libalias/alias_proxy.c

Modified: head/sys/netinet/libalias/alias_proxy.c
==============================================================================
--- head/sys/netinet/libalias/alias_proxy.c	Mon Mar 13 18:01:01 2017	(r315206)
+++ head/sys/netinet/libalias/alias_proxy.c	Mon Mar 13 18:05:31 2017	(r315207)
@@ -720,7 +720,8 @@ LibAliasProxyRule(struct libalias *la, c
 				err = RuleNumberDelete(la, rule_to_delete);
 				if (err)
 					ret = -1;
-				ret = 0;
+				else
+					ret = 0;
 				goto getout;
 			}