svn commit: r315091 - head/share/termcap

[Ngie Cooper (yaneurabeya)]

> On Mar 11, 2017, at 18:57, Ian Lepore <ian at FreeBSD.org> wrote:

…

> In an arm build sandbox I ran "make distribution DESTDIR=/tmp/ian" and
> this is what happened with termcap:
> 
>  --- etc-termcap ---
>  install -l rs /usr/share/misc/termcap /tmp/ian/etc/termcap
>  ...
>  revolution > file /tmp/ian/etc/termcap
>  /tmp/ian/etc/termcap: symbolic link to ../../../usr/share/misc/termcap
> 
> 
> Then I changed the rsymlink in share/termcap/Makefile to:
> 
> ${INSTALL_RSYMLINK} ${DESTDIR}/${BINDIR}/misc/termcap ${DESTDIR}/etc/termcap
> 
> and it did the right thing:
> 
>  --- etc-termcap ---
>  install -l rs /tmp/ian//usr/share/misc/termcap /tmp/ian/etc/termcap
>  ...
>  revolution > file /tmp/ian/etc/termcap
>  /tmp/ian/etc/termcap: symbolic link to ../usr/share/misc/termcap
> 
> 
> I haven't thought hard about whether adding DESTDIR like that would
> always fix the problem the right way.

	DESTDIR != “” is the key point to triggering the bug that was causing the failures I noted in my other email (it has nothing to do with arm specifically). Rod’s code will only work for DESTDIR == “”.
Thanks,
-Ngie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20170311/a76f0038/attachment.sig>