svn commit: r314657 - in head/kerberos5: . lib/libgssapi_krb5 lib/libgssapi_ntlm lib/libgssapi_spnego lib/libhdb lib/libkafs5 lib/libkrb5 libexec/hprop libexec/kpasswdd tools/asn1_compile tools/slc

[Bryan Drewery]

On 3/4/2017 12:20 PM, Rodney W. Grimes wrote:
> -- Start of PGP signed section.
> [ Charset windows-1252 unsupported, converting... ]
>> On 3/4/2017 7:34 AM, Rodney W. Grimes wrote:
>>> What is ${.CURDIR:H:H} ?????  Yes that seems to work but now we are obscuring
>>> ../.. into makefile syntax magic, probably not a grand idea.
>> It just trims off the last directory component.  This both reduces
>> namecache lookups, lessens the amount of data in a log, and makes
>> debugging a log simpler by not having a crazy path like:
>> /home/bdrewery/big/git/buildserver/sys/modules/usb/template/../../../dev/usb/template/usb_template.c
>>
>> It's far simpler to understand and work with:
>> /home/bdrewery/big/git/buildserver/sys/dev/usb/template/usb_template.c
>>
>> The only downside is it is slightly more obscure in a Makefile, but once
>> you know what :H is then it's not a problem.  This is why SRCTOP is even
>> better than this as it is far more clear than even :H and avoids the
>> ../../ problems.
> Lets do one or the other, but not both ${SRCTOP} and :H:H:H.  It appears
> that we now have a mix and mashed up some one way others the other.

That I can agree with. I would prefer to standardize on SRCTOP as :H is
too obscure without learning about make details.

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20170304/17377daa/attachment.sig>