svn commit: r314585 - head/usr.sbin/syslogd

Ngie Cooper (yaneurabeya) yaneurabeya at gmail.com
Fri Mar 3 07:15:24 UTC 2017


> On Mar 2, 2017, at 23:13, Ngie Cooper (yaneurabeya) <yaneurabeya at gmail.com> wrote:
> 
>> 
>> On Mar 2, 2017, at 22:49, Hiroki Sato <hrs at FreeBSD.org> wrote:
>> 
>> Ngie Cooper <ngie at FreeBSD.org> wrote
>> in <201703030613.v236DxDl010255 at repo.freebsd.org>:
>> 
>> ng> Author: ngie
>> ng> Date: Fri Mar  3 06:13:59 2017
>> ng> New Revision: 314585
>> ng> URL: https://svnweb.freebsd.org/changeset/base/314585
>> ng>
>> ng> Log:
>> ng>   Correct verb change for service => `*` after r314563
>> ng>
>> ng>   `*` means that packets will be received from a remote peer on any port.
>> ng>   Since the point of interest is the syslogd instance (not the remote peer),
>> ng>   the appropriate verb is "received", not "sent".
>> ng>
>> ng>   MFC after:	1 month
>> ng>   X-MFC with:	r314563
>> ng>   Sponsored by:	Dell EMC Isilon
>> ng>
>> ng> Modified:
>> ng>   head/usr.sbin/syslogd/syslogd.8
>> ng>
>> ng> Modified: head/usr.sbin/syslogd/syslogd.8
>> ng> ==============================================================================
>> ng> --- head/usr.sbin/syslogd/syslogd.8	Fri Mar  3 06:06:27 2017	(r314584)
>> ng> +++ head/usr.sbin/syslogd/syslogd.8	Fri Mar  3 06:13:59 2017	(r314585)
>> ng> @@ -131,7 +131,7 @@ A
>> ng>  .Ar service
>> ng>  of
>> ng>  .Ql \&*
>> ng> -allows packets to be sent from any UDP port.
>> ng> +allows packets to be received from any UDP port.
>> ng>  The default
>> ng>  .Ar service
>> 
>> It is incorrect that syslogd receives a UDP packet on any local port
>> when a "*" is specified.  This address validation is done by using
>> the source port number in a received UDP packet, so the point of
>> interest is the remote peer.
>> 
>> How about "...accepts UDP packets sent with any source port" or
>> something?
> 
> Yeah, that’s more accurate.

How about this?
-Ngie

$ svn diff usr.sbin/syslogd/syslogd.8
Index: usr.sbin/syslogd/syslogd.8
===================================================================
--- usr.sbin/syslogd/syslogd.8  (revision 314585)
+++ usr.sbin/syslogd/syslogd.8  (working copy)
@@ -131,7 +131,7 @@
 .Ar service
 of
 .Ql \&*
-allows packets to be received from any UDP port.
+allows UDP packets to be sent with any source port.
 The default
 .Ar service
 is
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20170302/e3c2a294/attachment.sig>


More information about the svn-src-all mailing list