svn commit: r320388 - head/sys/arm64/include

Andrew Turner andrew at freebsd.org
Tue Jun 27 17:06:24 UTC 2017


> On 27 Jun 2017, at 18:04, Ngie Cooper (yaneurabeya) <yaneurabeya at gmail.com> wrote:
> 
> 
>> On Jun 26, 2017, at 15:32, Andrew Turner <andrew at FreeBSD.org> wrote:
>> 
>> Author: andrew
>> Date: Mon Jun 26 22:32:52 2017
>> New Revision: 320388
>> URL: https://svnweb.freebsd.org/changeset/base/320388
>> 
>> Log:
>> In _bswap16 and _bswap32 cast constant values to the appropriate type. This is
>> similar to what is done in the x86 code.
>> 
>> Sponsored by:	DARPA, AFRL
> 
> Hi Andrew,
> 	This change broke htons use in libsdp on arm64. From https://ci.freebsd.org/job/FreeBSD-head-aarch64-build/2932/console :
> 
> 16:08:38 --- all_subdir_lib/libsdp ---
> 16:08:38 /usr/src/lib/libsdp/search.c:160:31: error: invalid operands to binary expression ('int' and 'uint8_t *' (aka 'unsigned char *'))
> 16:08:38                 xpdu.pdu.len = htons(req_cs - ss->req);
> 
> 16:08:38                                ~~~~~~~~~~~~~^~~~~~~~~~
> 
> 	It might be a good idea to revert the change, fix the fallout, then recommit the change.
> Thanks,
> -Ngie

I already fixed it in r320411.

Andrew


More information about the svn-src-all mailing list