svn commit: r319834 - in head: etc/mtree usr.bin/stat usr.bin/stat/tests

Ngie Cooper ngie at FreeBSD.org
Sun Jun 11 21:13:14 UTC 2017


Author: ngie
Date: Sun Jun 11 21:13:12 2017
New Revision: 319834
URL: https://svnweb.freebsd.org/changeset/base/319834

Log:
  Write up some basic tests for readlink(1)
  
  The tests exercise -f (f_flag), -n (n_flag), and no arguments (basic).
  
  MFC after:	1 month
  Sponsored by:	Dell EMC Isilon

Added:
  head/usr.bin/stat/tests/
  head/usr.bin/stat/tests/Makefile   (contents, props changed)
  head/usr.bin/stat/tests/readlink_test.sh   (contents, props changed)
Modified:
  head/etc/mtree/BSD.tests.dist
  head/usr.bin/stat/Makefile
  head/usr.bin/stat/stat.1

Modified: head/etc/mtree/BSD.tests.dist
==============================================================================
--- head/etc/mtree/BSD.tests.dist	Sun Jun 11 20:27:38 2017	(r319833)
+++ head/etc/mtree/BSD.tests.dist	Sun Jun 11 21:13:12 2017	(r319834)
@@ -670,6 +670,8 @@
         ..
         soelim
         ..
+        stat
+        ..
         tail
         ..
         tar

Modified: head/usr.bin/stat/Makefile
==============================================================================
--- head/usr.bin/stat/Makefile	Sun Jun 11 20:27:38 2017	(r319833)
+++ head/usr.bin/stat/Makefile	Sun Jun 11 21:13:12 2017	(r319834)
@@ -1,8 +1,12 @@
 # $FreeBSD$
 
+.include <src.opts.mk>
+
 PROG=	stat
 
 LINKS=	${BINDIR}/stat ${BINDIR}/readlink
 MLINKS=	stat.1 readlink.1
+
+SUBDIR.${MK_TESTS}+=	tests
 
 .include <bsd.prog.mk>

Modified: head/usr.bin/stat/stat.1
==============================================================================
--- head/usr.bin/stat/stat.1	Sun Jun 11 20:27:38 2017	(r319833)
+++ head/usr.bin/stat/stat.1	Sun Jun 11 21:13:12 2017	(r319834)
@@ -29,7 +29,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd April 22, 2012
+.Dd June 22, 2017
 .Dt STAT 1
 .Os
 .Sh NAME

Added: head/usr.bin/stat/tests/Makefile
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/usr.bin/stat/tests/Makefile	Sun Jun 11 21:13:12 2017	(r319834)
@@ -0,0 +1,5 @@
+# $FreeBSD$
+
+ATF_TESTS_SH+=	readlink_test
+
+.include <bsd.test.mk>

Added: head/usr.bin/stat/tests/readlink_test.sh
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/usr.bin/stat/tests/readlink_test.sh	Sun Jun 11 21:13:12 2017	(r319834)
@@ -0,0 +1,73 @@
+#
+# Copyright (c) 2017 Dell EMC
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1. Redistributions of source code must retain the above copyright
+#    notice, this list of conditions and the following disclaimer.
+# 2. Redistributions in binary form must reproduce the above copyright
+#    notice, this list of conditions and the following disclaimer in the
+#    documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+# ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
+# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+# OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+# HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+# LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+# OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+# SUCH DAMAGE.
+#
+# $FreeBSD$
+
+atf_test_case f_flag
+basic_head()
+{
+	atf_set	"descr" "Verify that calling readlink without any flags " \
+			"prints out the symlink target for a file"
+}
+basic_body()
+{
+	atf_check ln -s foo bar
+	atf_check -o inline:'foo\n' readlink bar
+}
+
+atf_test_case f_flag
+f_flag_head()
+{
+	atf_set	"descr" "Verify that calling readlink with -f will not emit " \
+			"an error message/exit with a non-zero code"
+}
+f_flag_body()
+{
+	atf_check touch A.file
+	atf_check ln -s nonexistent A.link
+	atf_check -o inline:"nonexistent\n" \
+	    -s exit:1 readlink A.file A.link
+	atf_check -o inline:"$(realpath A.file)\n$PWD/nonexistent\n" \
+	    -s exit:1 readlink -f A.file A.link
+}
+
+atf_test_case n_flag
+n_flag_head()
+{
+}
+n_flag_body()
+{
+	atf_check ln -s nonexistent.A A
+	atf_check ln -s nonexistent.B B
+	atf_check -o 'inline:nonexistent.A\nnonexistent.B\n' readlink A B
+	atf_check -o 'inline:nonexistent.Anonexistent.B' readlink -n A B
+}
+
+atf_init_test_cases()
+{
+	atf_add_test_case basic
+	atf_add_test_case f_flag
+	atf_add_test_case n_flag
+}


More information about the svn-src-all mailing list