svn commit: r319507 - head/sys/fs/msdosfs

Bryan Drewery bdrewery at FreeBSD.org
Sun Jun 4 18:06:31 UTC 2017


On 6/3/2017 12:05 AM, Bruce Evans wrote:
> bcopy() is essentially the same as memmove(), but is implemented more
> optimally
>   (the non-use of memmove() in the kernel used to be implememented by
>   by not having it, but someone broke this by adding an memmove() wrapper
>   which is an extern function that calls bcopy().  This is even slower than
>   the inline wrappers used to break intentionally leaving out some of the
>   other functions).

In r189170. It seems to me we should change systm.h back to a macro
#define memmove(dst, src, len) bcopy((src), (dst), (len))
And then keep the symbol in sys/libkern/memmove.c for
the cases where Clang insists on having the symbol for linking.

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20170604/99900545/attachment.sig>


More information about the svn-src-all mailing list