svn commit: r319295 - head/usr.bin/mkimg/tests

[Ngie Cooper (yaneurabeya)]

> On Jun 1, 2017, at 13:06, Alexey Dokuchaev <danfe at FreeBSD.org> wrote:
> 
> On Thu, Jun 01, 2017 at 11:27:18AM -0700, Ngie Cooper (yaneurabeya) wrote:
>> ...
>> I vote for not checking in the SHAs. If something fails (as someone else
>> mentioned on the lists), it's really hard to debug why it failed.
> 
> Like I've said, it's not "really" hard.  Check out previous version and
> generate image with correct hash, there is no strong reason to commit the
> image other than minor usability improvement of not having to check out
> previous version.
> 
> Then again, just my $.02 -- I'm not the one doing actual work here.

	That’s assuming there aren’t endianness issues, and less intuitive issues (take the usr.sbin/sa tests for example — BLEH). With binary files like this, it’s best to do an abbreviated dump of sorts.
Thanks,
-Ngie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20170601/283e2577/attachment.sig>