svn commit: r319295 - head/usr.bin/mkimg/tests

Alexey Dokuchaev danfe at FreeBSD.org
Thu Jun 1 17:16:43 UTC 2017


On Thu, Jun 01, 2017 at 09:58:38AM -0700, Simon J. Gerraty wrote:
> One option would be to store a sha256 hash of the result.
> If the image generated by the test hashes to the correct value - you
> pass.

That should be preferred.  Storing binary blobs in VCS is bad practice.

> Of course if the test fails, you are completely in the dark as to
> how/why.

Not really: you checkout previous version (which produces correct hash)
and store generated image for later inspection and diffing.

> Is storing img-1x1-512-mbr.vmdk.gz any more palatable?

This is barely acceptable, but only if image was zerofied/sparsed prior
to compression.  Also, the image should be of the minimal (sufficient)
working size.

./danfe


More information about the svn-src-all mailing list