svn commit: r319295 - head/usr.bin/mkimg/tests

[Pedro Giffuni]

On 06/01/17 01:06, Ngie Cooper (yaneurabeya) wrote:
>> On May 31, 2017, at 10:03 PM, Brooks Davis <brooks at FreeBSD.org> wrote:
>>
>> On Wed, May 31, 2017 at 08:01:12AM +0000, Ngie Cooper wrote:
>>> Author: ngie
>>> Date: Wed May 31 08:01:12 2017
>>> New Revision: 319295
>>> URL: https://svnweb.freebsd.org/changeset/base/319295
>>>
>>> Log:
>>>   Update the usr.bin/mkimg golden test output files after ^/head at r319125
>>>
>>>   ^/head at r319125 changed the location of the backup pmbr, requiring the
>>>   output files to be regenerated, since they're binary disk dumps.
>>>
>>>   The output files were regenerated with "make rebase"--fixed in
>>>   ^/head at r319294.
>> These should not be stored uuencoded.  It serves no purpose other
>> than bloating the repo and causing spammy commit mails like this one
>> where we got a huge tail of garbage output.
> Hi Brooks,
> 	I’m not entirely sure why the files were uuencoded to be honest. I think that’s a good question for Marcel and some of the folks at Juniper, since they wrote the tool/tests.

for the record, it used to be a common practice. I think it's legacy 
from the CVS days.

Pedro.