svn commit: r321370 - head/lib/libsysdecode

[John Baldwin]

On Sunday, July 23, 2017 06:03:48 PM Kristof Provost wrote:
> On 22 Jul 2017, at 17:42, Ngie Cooper (yaneurabeya) wrote:
> > > On Jul 22, 2017, at 5:51 AM, Kristof Provost <kp at FreeBSD.org> wrote:
> >>
> >> Author: kp
> >> Date: Sat Jul 22 12:51:19 2017
> >> New Revision: 321370
> >> URL: https://svnweb.freebsd.org/changeset/base/321370
> >>
> >> Log:
> >>  Handle WITH/WITHOUT_PF in libsysdecode
> >>
> >>  Only filter out the PF ioctls if we're building without pf support.
> >>  Until now those were always filtered out, so truss did not show 
> >> symbolic
> >>  names for pf ioctls.
> >
> >
> > Hi Kristof!
> > 	'MFC after:	1 week” should have probably be added to this commit.
> > 	This change should be MFCed to ^/stable/11 and probably ^/stable/10 
> > (in usr.sbin/kdump on 10: 
> > https://svnweb.freebsd.org/base/stable/10/usr.bin/kdump/mkioctls?revision=291815&view=markup#l25 
> > <https://svnweb.freebsd.org/base/stable/10/usr.bin/kdump/mkioctls?revision=291815&view=markup#l25>).
> 
> To be honest I wasn’t planning on MFCing this, because it’s not a 
> terribly important issue.
> That said, if it’d be useful to you (or anyone else) I’m certainly 
> willing to do so.
> 
> I’m not sure how much the code changed between 10 and 11, but MFC to 
> 11 should be easy, and if the changes are not too extensive I can do the 
> merge to 10 as well.

libsysdecode is not present in 10.  In 10 you'd have to patch the kdump
mkioctls script and the truss and kdump Makefile's.  I think it's probably
not worth the trouble to MFC to 10.  11 should probably merge fine, though
you'll have to tweak it since the previous change to remove the disk hack
can't be MFC'.d :(  Your original version of the patch would be fine for
11 though.

-- 
John Baldwin