svn commit: r321145 - stable/11/lib/libc/sys

Ngie Cooper ngie at FreeBSD.org
Tue Jul 18 18:15:30 UTC 2017


Author: ngie
Date: Tue Jul 18 18:15:28 2017
New Revision: 321145
URL: https://svnweb.freebsd.org/changeset/base/321145

Log:
  MFC r318715,r318717,r318718,r318719,r318720,r318721:
  
  r318715:
  
  _umtx_op(2): fix minor manlint issues
  
  - Sort .Xr entries in SEE ALSO section.
  - Sort SEE ALSO and STANDARDS sections properly, in terms of the
    entire document.
  
  r318717:
  
  cap_enter(2): fix manlint issues
  
  - Sort SEE ALSO section appropriately.
  - Correct section for sysctl(9).
  
  r318718:
  
  rctl_add_rule(2): fix manlint warnings
  
  - Fix commas (either missing or misused) after .Nm entries in SYNOPSIS
  
  r318719:
  
  open(2): fix manlint warnings
  
  - Sort SEE ALSO .Xr entries.
  - Sort sections (HISTORY comes after STANDARDS).
  
  r318720:
  
  ptrace(2): clean up trailing whitespace
  
  r318721:
  
  kill(2): add missing section for sysctl(9)

Modified:
  stable/11/lib/libc/sys/_umtx_op.2
  stable/11/lib/libc/sys/cap_enter.2
  stable/11/lib/libc/sys/kill.2
  stable/11/lib/libc/sys/open.2
  stable/11/lib/libc/sys/ptrace.2
  stable/11/lib/libc/sys/rctl_add_rule.2
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/lib/libc/sys/_umtx_op.2
==============================================================================
--- stable/11/lib/libc/sys/_umtx_op.2	Tue Jul 18 18:09:26 2017	(r321144)
+++ stable/11/lib/libc/sys/_umtx_op.2	Tue Jul 18 18:15:28 2017	(r321145)
@@ -28,7 +28,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd May 29, 2016
+.Dd May 23, 2017
 .Dt _UMTX_OP 2
 .Os
 .Sh NAME
@@ -1382,32 +1382,11 @@ Mutex lock requests without timeout specified are rest
 The error is not returned to userspace code since restart
 is handled by usual adjustment of the instruction counter.
 .El
-.Sh BUGS
-A window between a unlocking robust mutex and resetting the pointer in the
-.Dv robust_inact_offset
-member of the registered
-.Vt struct umtx_robust_lists_params
-allows another thread to destroy the mutex, thus making the kernel inspect
-freed or reused memory.
-The
-.Li libthr
-implementation is only vulnerable to this race when operating on
-a shared mutex.
-A possible fix for the current implementation is to strengthen the checks
-for shared mutexes before terminating them, in particular, verifying
-that the mutex memory is mapped from a shared memory object allocated
-by the
-.Dv UMTX_OP_SHM
-request.
-This is not done because it is believed that the race is adequately
-covered by other consistency checks, while adding the check would
-prevent alternative implementations of
-.Li libpthread .
 .Sh SEE ALSO
 .Xr clock_gettime 2 ,
 .Xr mmap 2 ,
-.Xr shm_open 2 ,
 .Xr setrlimit 2 ,
+.Xr shm_open 2 ,
 .Xr sigaction 2 ,
 .Xr thr_exit 2 ,
 .Xr thr_kill 2 ,
@@ -1425,3 +1404,24 @@ to implement
 .St -p1003.1-2001
 .Xr pthread 3
 functionality.
+.Sh BUGS
+A window between a unlocking robust mutex and resetting the pointer in the
+.Dv robust_inact_offset
+member of the registered
+.Vt struct umtx_robust_lists_params
+allows another thread to destroy the mutex, thus making the kernel inspect
+freed or reused memory.
+The
+.Li libthr
+implementation is only vulnerable to this race when operating on
+a shared mutex.
+A possible fix for the current implementation is to strengthen the checks
+for shared mutexes before terminating them, in particular, verifying
+that the mutex memory is mapped from a shared memory object allocated
+by the
+.Dv UMTX_OP_SHM
+request.
+This is not done because it is believed that the race is adequately
+covered by other consistency checks, while adding the check would
+prevent alternative implementations of
+.Li libpthread .

Modified: stable/11/lib/libc/sys/cap_enter.2
==============================================================================
--- stable/11/lib/libc/sys/cap_enter.2	Tue Jul 18 18:09:26 2017	(r321144)
+++ stable/11/lib/libc/sys/cap_enter.2	Tue Jul 18 18:15:28 2017	(r321145)
@@ -28,7 +28,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd September 27, 2016
+.Dd May 23, 2017
 .Dt CAP_ENTER 2
 .Os
 .Sh NAME
@@ -139,11 +139,11 @@ points outside the process's allocated address space.
 .Xr cap_fcntls_limit 2 ,
 .Xr cap_ioctls_limit 2 ,
 .Xr cap_rights_limit 2 ,
-.Xr procctl 2 ,
-.Xr sysctl 2 ,
 .Xr fexecve 2 ,
+.Xr procctl 2 ,
 .Xr cap_sandboxed 3 ,
-.Xr capsicum 4
+.Xr capsicum 4 ,
+.Xr sysctl 9
 .Sh HISTORY
 Support for capabilities and capabilities mode was developed as part of the
 .Tn TrustedBSD

Modified: stable/11/lib/libc/sys/kill.2
==============================================================================
--- stable/11/lib/libc/sys/kill.2	Tue Jul 18 18:09:26 2017	(r321144)
+++ stable/11/lib/libc/sys/kill.2	Tue Jul 18 18:15:28 2017	(r321145)
@@ -71,7 +71,7 @@ A single exception is the signal SIGCONT, which may al
 to any process with the same session ID as the sender.
 In addition, if the
 .Va security.bsd.conservative_signals
-.Xr sysctl
+.Xr sysctl 9
 is set to 1, the user is not a super-user, and
 the receiver is set-uid, then
 only job control and terminal control signals may

Modified: stable/11/lib/libc/sys/open.2
==============================================================================
--- stable/11/lib/libc/sys/open.2	Tue Jul 18 18:09:26 2017	(r321144)
+++ stable/11/lib/libc/sys/open.2	Tue Jul 18 18:15:28 2017	(r321145)
@@ -471,16 +471,8 @@ is specified and the file is not a directory.
 .Xr read 2 ,
 .Xr umask 2 ,
 .Xr write 2 ,
-.Xr fopen 3
-.Sh HISTORY
-The
-.Fn open
-function appeared in
-.At v6 .
-The
-.Fn openat
-function was introduced in
-.Fx 8.0 .
+.Xr fopen 3 ,
+.Xr capsicum 4
 .Sh STANDARDS
 These functions are specified by
 .St -p1003.1-2008 .
@@ -497,6 +489,15 @@ when
 is set in flags and the final component of pathname is a symbolic link
 to distinguish it from the case of too many symbolic link traversals
 in one of its non-final components.
+.Sh HISTORY
+The
+.Fn open
+function appeared in
+.At v6 .
+The
+.Fn openat
+function was introduced in
+.Fx 8.0 .
 .Sh BUGS
 The Open Group Extended API Set 2 specification requires that the test
 for whether

Modified: stable/11/lib/libc/sys/ptrace.2
==============================================================================
--- stable/11/lib/libc/sys/ptrace.2	Tue Jul 18 18:09:26 2017	(r321144)
+++ stable/11/lib/libc/sys/ptrace.2	Tue Jul 18 18:15:28 2017	(r321145)
@@ -166,7 +166,7 @@ new child processes will execute without tracing enabl
 This event flag controls tracing of LWP
 .Pq kernel thread
 creation and destruction.
-When this event is enabled, 
+When this event is enabled,
 new LWPs will stop and report an event with
 .Dv PL_FLAG_BORN
 set before executing their first instruction,
@@ -215,7 +215,7 @@ or
 includes only
 .Dv PTRACE_EXEC
 events.
-All other event flags are disabled. 
+All other event flags are disabled.
 .Pp
 The
 .Fa request

Modified: stable/11/lib/libc/sys/rctl_add_rule.2
==============================================================================
--- stable/11/lib/libc/sys/rctl_add_rule.2	Tue Jul 18 18:09:26 2017	(r321144)
+++ stable/11/lib/libc/sys/rctl_add_rule.2	Tue Jul 18 18:15:28 2017	(r321145)
@@ -28,10 +28,10 @@
 .Dt RCTL_ADD_RULE 2
 .Os
 .Sh NAME
-.Nm rctl_add_rule,
-.Nm rctl_get_limits
-.Nm rctl_get_racct,
-.Nm rctl_get_rules,
+.Nm rctl_add_rule ,
+.Nm rctl_get_limits ,
+.Nm rctl_get_racct ,
+.Nm rctl_get_rules ,
 .Nm rctl_remove_rule
 .Nd manipulate and query the resource limits database
 .Sh LIBRARY


More information about the svn-src-all mailing list