svn commit: r320587 - stable/10/usr.sbin/rpc.lockd
Xin LI
delphij at FreeBSD.org
Mon Jul 3 05:30:33 UTC 2017
Author: delphij
Date: Mon Jul 3 05:30:31 2017
New Revision: 320587
URL: https://svnweb.freebsd.org/changeset/base/320587
Log:
MFC r320093: Check return value of seteuid() and bail out if we fail.
Modified:
stable/10/usr.sbin/rpc.lockd/lock_proc.c
Directory Properties:
stable/10/ (props changed)
Modified: stable/10/usr.sbin/rpc.lockd/lock_proc.c
==============================================================================
--- stable/10/usr.sbin/rpc.lockd/lock_proc.c Mon Jul 3 05:22:10 2017 (r320586)
+++ stable/10/usr.sbin/rpc.lockd/lock_proc.c Mon Jul 3 05:30:31 2017 (r320587)
@@ -283,7 +283,10 @@ get_client(host_addr, vers)
/* Regain root privileges, for bindresvport. */
old_euid = geteuid();
- seteuid(0);
+ if (seteuid(0) != 0) {
+ syslog(LOG_ERR, "seteuid(0) failed");
+ return NULL;
+ }
/*
* Bind the client FD to a reserved port.
@@ -292,7 +295,10 @@ get_client(host_addr, vers)
bindresvport(clnt_fd, NULL);
/* Drop root privileges again. */
- seteuid(old_euid);
+ if (seteuid(old_euid) != 0) {
+ syslog(LOG_ERR, "seteuid(%d) failed", old_euid);
+ return NULL;
+ }
/* Success - update the cache entry */
clnt_cache_ptr[clnt_cache_next_to_use] = client;
More information about the svn-src-all
mailing list