svn commit: r312103 - head/tests/sys/vfs

Ngie Cooper (yaneurabeya) yaneurabeya at gmail.com
Sat Jan 14 02:19:40 UTC 2017


> On Jan 13, 2017, at 17:07, Ngie Cooper (yaneurabeya) <yaneurabeya at gmail.com> wrote:
> 
> 
>> On Jan 13, 2017, at 17:06, Ngie Cooper (yaneurabeya) <yaneurabeya at gmail.com> wrote:
>> 
>>> 
>>> On Jan 13, 2017, at 17:03, Conrad E. Meyer <cem at FreeBSD.org> wrote:
>>> 
>>> Author: cem
>>> Date: Sat Jan 14 01:03:20 2017
>>> New Revision: 312103
>>> URL: https://svnweb.freebsd.org/changeset/base/312103
>>> 
>>> Log:
>>> Revert r310994
>>> 
>>> Don't implement some terrible hack on a test by test basis.  The
>>> framework fix is straightforward and can be chased up in the original
>>> bug.
>>> 
>>> Reviewed by:	ngie ("be my guest")
>> 
>> You should have filed an issue with atf/kyua, had the fix done, then done the necessary parts in releasing a new port/package. Please disable the test because it doesn’t work at all right now on CURRENT and it will ping the sh’t out of the jenkins email until fixed.
>> -Ngie
> 
> PS Saying “be my guest” isn’t review in any shape or form, nor is it my consent towards your change being implemented now.

Oh yeah… this commit broke the build too because I turned on WARNS: https://jenkins.freebsd.org/job/FreeBSD_HEAD_i386/4653/
Cheers,
-Ngie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20170113/7e3c95eb/attachment.sig>


More information about the svn-src-all mailing list