svn commit: r312001 - head/sys/x86/x86

[Pedro F. Giffuni]

Author: pfg
Date: Fri Jan 13 01:39:19 2017
New Revision: 312001
URL: https://svnweb.freebsd.org/changeset/base/312001

Log:
  Remove __nonnull() attributes from x86 machine check architecture.
  
  These are of the few cases where we use the GCC non-null attributes in
  non-header code. As part of a review [1] of our use of such attributes we
  are replacing such uses of the overly aggressive GCC attribute with clang's
  _Nonnull attribute.
  
  In this case the attributes serve little purpose as they just don't
  enforce run time checks, If anything the attributes would cause NULL pointer
  checks to be ignored but there are no such checks so only effect is
  cosmetic.
  
  The references appear to be left over from code development and likely
  already fulfilled their purpose.
  
  Reference [1]:
  https://reviews.freebsd.org/D9004
  
  Reviewed by:	jhb
  MFC after:	3 weeks

Modified:
  head/sys/x86/x86/mca.c

Modified: head/sys/x86/x86/mca.c
==============================================================================
--- head/sys/x86/x86/mca.c	Thu Jan 12 22:36:25 2017	(r312000)
+++ head/sys/x86/x86/mca.c	Fri Jan 13 01:39:19 2017	(r312001)
@@ -247,7 +247,7 @@ mca_error_mmtype(uint16_t mca_error)
 	return ("???");
 }
 
-static int __nonnull(1)
+static int
 mca_mute(const struct mca_record *rec)
 {
 
@@ -276,7 +276,7 @@ mca_mute(const struct mca_record *rec)
 }
 
 /* Dump details about a single machine check. */
-static void __nonnull(1)
+static void
 mca_log(const struct mca_record *rec)
 {
 	uint16_t mca_error;
@@ -415,7 +415,7 @@ mca_log(const struct mca_record *rec)
 		printf("MCA: Misc 0x%llx\n", (long long)rec->mr_misc);
 }
 
-static int __nonnull(2)
+static int
 mca_check_status(int bank, struct mca_record *rec)
 {
 	uint64_t status;
@@ -482,7 +482,7 @@ mca_refill(void *context, int pending)
 	mca_fill_freelist();
 }
 
-static void __nonnull(2)
+static void
 mca_record_entry(enum scan_mode mode, const struct mca_record *record)
 {
 	struct mca_internal *rec;