svn commit: r311929 - head/sys/boot/common

[Dimitry Andric]

On 11 Jan 2017, at 23:32, Ngie Cooper <yaneurabeya at gmail.com> wrote:
> 
> On Wed, Jan 11, 2017 at 2:10 PM, Dimitry Andric <dim at freebsd.org> wrote:
> 
> ...
> 
>> The line:
>> 
>>    extern int errno;
>> 
>> expanded to:
>> 
>>    extern int (* __error());
>> 
>> which is a declaration of an external function pointer called __error
>> (albeit with an empty parameter list).  Since nobody actually refers to
>> this symbol in libstand, there are no later complaints.
>> 
>> Interestingly, reloc_elf.c does not use errno at all, so I have no idea
>> why the include was originally added.
> 
> This is why:
> 
> 95dd728f5ca86 (iedowse  2004-08-28 23:03:05 +0000 221) #else
> 95dd728f5ca86 (iedowse  2004-08-28 23:03:05 +0000 222)  return (EOPNOTSUPP);
> 95dd728f5ca86 (iedowse  2004-08-28 23:03:05 +0000 223) #endif
> 
> You probably just broke tinderbox on non-x86/-powerpc.

Not very likely, since <stand.h> includes <sys/errno.h>.

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20170111/56baca63/attachment.sig>