svn commit: r311667 - in head/sys/contrib/dev/acpica: components/namespace components/tables include

[Ngie Cooper (yaneurabeya)]

> On Jan 8, 2017, at 18:24, Jan Beich <jbeich at freebsd.org> wrote:
> 
> "Conrad E. Meyer" <cem at FreeBSD.org> writes:
> 
>> +++ head/sys/contrib/dev/acpica/components/tables/tbxface.c	Sun Jan  8 06:26:33 2017	(r311667)
>> @@ -314,11 +314,12 @@ ACPI_EXPORT_SYMBOL (AcpiGetTableHeader)
>> 
>> /*******************************************************************************
>>  *
>> - * FUNCTION:    AcpiGetTable
>> + * FUNCTION:    AcpiGetTableWithSize
>>  *
>>  * PARAMETERS:  Signature           - ACPI signature of needed table
>>  *              Instance            - Which instance (for SSDTs)
>>  *              OutTable            - Where the pointer to the table is returned
>> + *              TblSize             - Size of the table
>>  *
>>  * RETURN:      Status and pointer to the requested table
>>  *
>> @@ -333,10 +334,11 @@ ACPI_EXPORT_SYMBOL (AcpiGetTableHeader)
>>  ******************************************************************************/
>> 
>> ACPI_STATUS
>> -AcpiGetTable (
>> +AcpiGetTableWithSize (
> 
> Can you adjust ACPI_EXPORT_SYMBOL() as well? It doesn't make sense to
> export AcpiGetTable() twice but compiler won't complain if you do.

Depends on the compiler and the version. IIRC clang won’t, but gcc will (depending on the version).
Cheers,
-Ngie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20170108/62a060af/attachment.sig>