svn commit: r310889 - head/tools/build/mk

[Dimitry Andric]

On 31 Dec 2016, at 07:07, Jung-uk Kim <jkim at FreeBSD.org> wrote:
> 
> Author: jkim
> Date: Sat Dec 31 06:07:48 2016
> New Revision: 310889
> URL: https://svnweb.freebsd.org/changeset/base/310889
> 
> Log:
>  Do not remove llvm-objdump.  It is installed by default since r310840.
> 
> Modified:
>  head/tools/build/mk/OptionalObsoleteFiles.inc
> 
> Modified: head/tools/build/mk/OptionalObsoleteFiles.inc
> ==============================================================================
> --- head/tools/build/mk/OptionalObsoleteFiles.inc	Sat Dec 31 03:07:48 2016	(r310888)
> +++ head/tools/build/mk/OptionalObsoleteFiles.inc	Sat Dec 31 06:07:48 2016	(r310889)
> @@ -1484,7 +1484,6 @@ OLD_FILES+=usr/bin/llvm-link
> OLD_FILES+=usr/bin/llvm-lto
> OLD_FILES+=usr/bin/llvm-mc
> OLD_FILES+=usr/bin/llvm-nm
> -OLD_FILES+=usr/bin/llvm-objdump
> OLD_FILES+=usr/bin/llvm-pdbdump
> OLD_FILES+=usr/bin/llvm-rtdyld
> OLD_FILES+=usr/bin/llvm-symbolizer

This block is under MK_CLANG_EXTRAS.  Shouldn't llvm-objdump be moved to
the MK_CLANG block just above instead?  Otherwise it would never be
cleaned up, if somebody disabled llvm/clang completely.

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20170104/c159c7ed/attachment.sig>