svn commit: r313859 - in head/sys: kern sys

Mateusz Guzik mjguzik at gmail.com
Tue Feb 21 01:35:16 UTC 2017


On Fri, Feb 17, 2017 at 09:15:00PM +1100, Bruce Evans wrote:
> On Fri, 17 Feb 2017, Hans Petter Selasky wrote:
> 
> >>Log:
> >>  Introduce SCHEDULER_STOPPED_TD for use when the thread pointer
> >>was already read
> >>
> >>  Sprinkle in few places.
> >>
> >>Modified:
> >>  head/sys/kern/kern_condvar.c
> >>  head/sys/kern/kern_synch.c
> >>  head/sys/sys/systm.h
> >
> >Do these checks also cover panics? Or only shutdown?
> 
> This is just an optimization.
> 
> I don't like it because it moves further from moving the stopped flag
> back out of the thread to a global.
> 

I only did this to make it more feasible to remove the tid argument from
primitives which I may or may not end up doing, undecided yet.

As for changing the conditon to testing a global, I don't think this
change affects feasibilitly. It onlly requires some more churn by hand
which I'm happy to do if said change is implemented.

-- 
Mateusz Guzik <mjguzik gmail.com>


More information about the svn-src-all mailing list