svn commit: r313962 - in head: etc/mtree sys/boot/geli sys/geom/eli tests/sys/geom tests/sys/geom/eli tests/sys/geom/eli/pbkdf2

Ngie Cooper (yaneurabeya) yaneurabeya at gmail.com
Sun Feb 19 21:12:18 UTC 2017


> On Feb 19, 2017, at 13:07, Allan Jude <allanjude at freebsd.org> wrote:

…

> Sorry, I didn't think it actually built these tests unless testvect.h
> did not exist.
> 
> These tests were written by jmg@, years ago, but by me.
> 
> What do you think the best course of action is? Just disconnect this test?

	To be safe, I’d probably just disconnect the dependency since the generated file (I assume) works by itself, e.g.

$ svn diff tests/sys/geom/eli/pbkdf2/Makefile
Index: tests/sys/geom/eli/pbkdf2/Makefile
===================================================================
--- tests/sys/geom/eli/pbkdf2/Makefile  (revision 313971)
+++ tests/sys/geom/eli/pbkdf2/Makefile  (working copy)
@@ -22,7 +22,7 @@

 LIBADD.pbkdf2= crypto

-testvect.h:    gentestvect.py
+testvect.h:
        python gentestvect.py > $@

 .include <bsd.test.mk>

	We can work on removing the python dependency in the interim.
Thanks,
-Ngie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20170219/2243e516/attachment.sig>


More information about the svn-src-all mailing list