svn commit: r313822 - in head/sys: libkern netinet

[Ngie Cooper]

On Thu, Feb 16, 2017 at 4:16 PM, Ngie Cooper <yaneurabeya at gmail.com> wrote:
> On Thu, Feb 16, 2017 at 12:50 PM, Eric van Gyzen <vangyzen at freebsd.org> wrote:
>> Author: vangyzen
>> Date: Thu Feb 16 20:50:01 2017
>> New Revision: 313822
>> URL: https://svnweb.freebsd.org/changeset/base/313822
>>
>> Log:
>>   Remove inet_ntoa() from the kernel
>>
>>   inet_ntoa() cannot be used safely in a multithreaded environment
>>   because it uses a static local buffer.  Remove it from the kernel.
>
> Uhmmmm.... did you mean to remove it from netinet/in.h ? This gets
> used in userspace too...

Oh good grief -- there were 3 definitions??? Ok, I see you deleted the
libkern one. Nevermind... carry on!
-Ngie

$ grep -r inet_ntoa /usr/include/
/usr/include/netinet/in.h:char  *inet_ntoa(struct in_addr); /* in libkern */
/usr/include/netinet/in.h:char  *inet_ntoa_r(struct in_addr ina, char
*buf); /* in libkern */
/usr/include/arpa/inet.h:#define        inet_ntoa               __inet_ntoa
/usr/include/arpa/inet.h:#define        inet_ntoa_r             __inet_ntoa_r
/usr/include/arpa/inet.h:/*const*/ char *inet_ntoa(struct in_addr);
/usr/include/arpa/inet.h:char           *inet_ntoa_r(struct in_addr,
char *buf, socklen_t size);
$