svn commit: r313675 - in head/sys: netinet netinet6

[Cy Schubert]

In message <201702120656.v1C6uXp1008956 at repo.freebsd.org>, 
=?UTF-8?Q?Ermal_Lu=c
3=a7i?= writes:
> Author: eri
> Date: Sun Feb 12 06:56:33 2017
> New Revision: 313675
> URL: https://svnweb.freebsd.org/changeset/base/313675
> 
> Log:
>   Committed without approval from mentor.

This commit log message is objectionable and totally inappropriate. 
Revision numbers please?

Providing the revision numbers after the fact doesn't completely address my 
objection to the incompleteness of this commit log message because the 
commit log is now incomplete for all posterity. The revision numbers are 
missing from the commit log and anyone going through the history of the 
affected sources (I do that a lot) has no clue, except to try to piece 
together what was backed out and search for replies to commit email to 
provide a complete picture of what was done. Vital information is missing 
from the commit log. Searching for answers to these questions is time 
consuming and incomplete documentation is inconsiderate and disrespectful 
of those who follow on figure out what and why.

Looking up mentor/mentee relationships, one can safely assume that your 
mentor requested the backout. This too should have been documented in the 
commit log message, e.g. "(mentor)".

At the very least revision numbers should be documented in a follow up 
eamil.


-- 
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.