svn commit: r313564 - head/sys/kern

John Baldwin jhb at freebsd.org
Fri Feb 10 19:38:46 UTC 2017


On Friday, February 10, 2017 07:25:52 PM John Baldwin wrote:
> Author: jhb
> Date: Fri Feb 10 19:25:52 2017
> New Revision: 313564
> URL: https://svnweb.freebsd.org/changeset/base/313564
> 
> Log:
>   Drop the "created from" line from files generated by makesyscalls.sh.
>   
>   This information is less useful when the generated files are included in
>   source control along with the source.  If needed it can be reconstructed
>   from the $FreeBSD$ tag in the generated file.  Removing this information
>   from the generated output permits committing the generated files along
>   with the change to the system call master list without having inconsistent
>   metadata in the generated files.

There is a tradeoff of course.  Having the generated files mixed in the
commits does make the diff more noisy, and it can be more of a pain in reviews.
One can still just not include the generated files when posting reviews (we
already have to do that because you have to generate the files to do testing).

However, I do think that at least for MFCs we should include the generated
files in the merge so that on stable branches we don't have known-broken
commits once this change is merged back to stable branches.

-- 
John Baldwin


More information about the svn-src-all mailing list