svn commit: r313437 - head/lib/libutil

Ngie Cooper (yaneurabeya) yaneurabeya at gmail.com
Wed Feb 8 09:53:00 UTC 2017


> On Feb 8, 2017, at 01:38, Sergey Kandaurov <pluknet at gmail.com> wrote:
> 
> On 8 February 2017 at 12:22, Ngie Cooper <ngie at freebsd.org> wrote:
> Author: ngie
> Date: Wed Feb  8 09:22:35 2017
> New Revision: 313437
> URL: https://svnweb.freebsd.org/changeset/base/313437
> 
> Log:
>   Create link from hexdump(3) to sbuf_hexdump(9) as the manpage describes
>   sbuf_hexdump(9)'s behavior
> 
>   MFC after:    3 weeks
>   Sponsored by: Dell EMC Isilon
> 
> Modified:
>   head/lib/libutil/Makefile
> 
> Modified: head/lib/libutil/Makefile
> ==============================================================================
> --- head/lib/libutil/Makefile   Wed Feb  8 09:19:49 2017        (r313436)
> +++ head/lib/libutil/Makefile   Wed Feb  8 09:22:35 2017        (r313437)
> @@ -35,6 +35,7 @@ MAN+= expand_number.3 flopen.3 fparseln.
>         property.3 pty.3 quotafile.3 realhostname.3 realhostname_sa.3 \
>         _secure_path.3 trimdomain.3 uucplock.3 pw_util.3
>  MAN+=  login.conf.5
> +MLINKS+=hexdump.3 sbuf_hexdump.9
> 
> This looks odd imho also that sbuf_hexdump(3) is part of libsbuf.
> Note also hexdump(3) taht's essential copy of hexdump(9).
> If go this duplicating route why not copy sbuf_hexdump description as well.
> 
> I like more how that's done with sbuf(9) that's the only man page, ymmv.

Ack. The implementation is spread between iexdump(3) and sbuf(9), but probably should just be in sbuf(9). I’ll look at cleaning this up further after I talk with scottl@ a bit more.
Thanks!
-Ngie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20170208/08517d05/attachment.sig>


More information about the svn-src-all mailing list