svn commit: r327423 - in head/sys: kern sys

Colin Percival cperciva at FreeBSD.org
Sun Dec 31 09:21:02 UTC 2017


Author: cperciva
Date: Sun Dec 31 09:21:01 2017
New Revision: 327423
URL: https://svnweb.freebsd.org/changeset/base/327423

Log:
  Code for recording timestamps of events, especially function entries/exits.
  This is a very primitive system, intended for use in measuring performance
  during the early system boot, before more sophisticated tools like DTrace
  or infrastructure like kernel memory allocation and mutexes are available.
  
  Because this code records pointers to strings rather than copying strings
  (in order to keep the memory usage more manageable), if a kernel module is
  unloaded after logging an event, Bad Things can happen.  Users are advised
  to not do that.
  
  Since cycle counts from the early kernel boot are used as an initial entropy
  source, publishing this information to userland could result in inadequate
  entropy being kept private to the kernel RNG.  Users are advised to not
  enable this on systems with untrusted users.
  
  Discussed on:	freebsd-current

Added:
  head/sys/kern/kern_tslog.c   (contents, props changed)
  head/sys/sys/tslog.h   (contents, props changed)

Added: head/sys/kern/kern_tslog.c
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/sys/kern/kern_tslog.c	Sun Dec 31 09:21:01 2017	(r327423)
@@ -0,0 +1,118 @@
+/*-
+ * Copyright (c) 2017 Colin Percival
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+ * SUCH DAMAGE.
+ */
+
+#include <sys/cdefs.h>
+__FBSDID("$FreeBSD$");
+
+#include <sys/param.h>
+#include <sys/sbuf.h>
+#include <sys/sysctl.h>
+#include <sys/systm.h>
+#include <sys/tslog.h>
+
+#include <machine/atomic.h>
+#include <machine/cpu.h>
+
+#ifndef TSLOGSIZE
+#define TSLOGSIZE 262144
+#endif
+
+static volatile long nrecs = 0;
+static struct timestamp {
+	void * td;
+	int type;
+	const char * f;
+	const char * s;
+	uint64_t tsc;
+} timestamps[TSLOGSIZE];
+
+void
+tslog(void * td, int type, const char * f, const char * s)
+{
+	uint64_t tsc = get_cyclecount();
+	long pos;
+
+	/* Grab a slot. */
+	pos = atomic_fetchadd_long(&nrecs, 1);
+
+	/* Store record. */
+	if (pos < nitems(timestamps)) {
+		timestamps[pos].td = td;
+		timestamps[pos].type = type;
+		timestamps[pos].f = f;
+		timestamps[pos].s = s;
+		timestamps[pos].tsc = tsc;
+	}
+}
+
+static int
+sysctl_debug_tslog(SYSCTL_HANDLER_ARGS)
+{
+	int error;
+	struct sbuf *sb;
+	size_t i, limit;
+
+	/*
+	 * This code can race against the code in tslog() which stores
+	 * records: Theoretically we could end up reading a record after
+	 * its slots have been reserved but before it has been written.
+	 * Since this code takes orders of magnitude longer to run than
+	 * tslog() takes to write a record, it is highly unlikely that
+	 * anyone will ever experience this race.
+	 */
+	sb = sbuf_new_for_sysctl(NULL, NULL, 1024, req);
+	limit = MIN(nrecs, nitems(timestamps));
+	for (i = 0; i < limit; i++) {
+		sbuf_printf(sb, "%p", timestamps[i].td);
+		sbuf_printf(sb, " %llu",
+		    (unsigned long long)timestamps[i].tsc);
+		switch (timestamps[i].type) {
+		case TS_ENTER:
+			sbuf_printf(sb, " ENTER");
+			break;
+		case TS_EXIT:
+			sbuf_printf(sb, " EXIT");
+			break;
+		case TS_THREAD:
+			sbuf_printf(sb, " THREAD");
+			break;
+		case TS_EVENT:
+			sbuf_printf(sb, " EVENT");
+			break;
+		}
+		sbuf_printf(sb, " %s", timestamps[i].f ? timestamps[i].f : "(null)");
+		if (timestamps[i].s)
+			sbuf_printf(sb, " %s\n", timestamps[i].s);
+		else
+			sbuf_printf(sb, "\n");
+	}
+	error = sbuf_finish(sb);
+	sbuf_delete(sb);
+	return (error);
+}
+
+SYSCTL_PROC(_debug, OID_AUTO, tslog, CTLTYPE_STRING|CTLFLAG_RD|CTLFLAG_MPSAFE,
+    0, 0, sysctl_debug_tslog, "", "Dump recorded event timestamps");

Added: head/sys/sys/tslog.h
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/sys/sys/tslog.h	Sun Dec 31 09:21:01 2017	(r327423)
@@ -0,0 +1,60 @@
+/*-
+ * Copyright (c) 2017 Colin Percival
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
+ * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
+ * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
+ * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
+ * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * $FreeBSD$
+ */
+
+#ifndef _TSLOG_H_
+#define	_TSLOG_H_
+
+#include <sys/_types.h>
+#include <sys/pcpu.h>
+
+#define TS_ENTER	0
+#define TS_EXIT		1
+#define TS_THREAD	2
+#define TS_EVENT	3
+
+#define TSENTER() TSRAW(curthread, TS_ENTER, __func__, NULL)
+#define TSENTER2(x) TSRAW(curthread, TS_ENTER, __func__, x)
+#define TSEXIT() TSRAW(curthread, TS_EXIT, __func__, NULL)
+#define TSEXIT2(x) TSRAW(curthread, TS_EXIT, __func__, x)
+#define TSTHREAD(td, x) TSRAW(td, TS_THREAD, x, NULL)
+#define TSEVENT(x) TSRAW(curthread, TS_EVENT, x, NULL)
+#define TSEVENT2(x, y) TSRAW(curthread, TS_EVENT, x, y)
+#define TSLINE() TSEVENT2(__FILE__, __XSTRING(__LINE__))
+#define TSWAIT(x) TSEVENT2("WAIT", x);
+#define TSUNWAIT(x) TSEVENT2("UNWAIT", x);
+#define TSHOLD(x) TSEVENT2("HOLD", x);
+#define TSRELEASE(x) TSEVENT2("RELEASE", x);
+
+#ifdef TSLOG
+#define TSRAW(a, b, c, d) tslog(a, b, c, d)
+void tslog(void *, int, const char *, const char *);
+#else
+#define TSRAW(a, b, c, d)		/* Timestamp logging disabled */
+#endif
+
+#endif /* _TSLOG_H_ */


More information about the svn-src-all mailing list