svn commit: r327379 - head/sys/isa

[Rodney W. Grimes]

[ Charset UTF-8 unsupported, converting... ]
> Author: imp
> Date: Sat Dec 30 08:16:31 2017
> New Revision: 327379
> URL: https://svnweb.freebsd.org/changeset/base/327379
> 
> Log:
>   On further testing on actual machines with this hardware, we should
>   only warn for devices that are attached. Add missing \n.
> 
> Modified:
>   head/sys/isa/isa_common.c
> 
> Modified: head/sys/isa/isa_common.c
> ==============================================================================
> --- head/sys/isa/isa_common.c	Sat Dec 30 07:59:32 2017	(r327378)
> +++ head/sys/isa/isa_common.c	Sat Dec 30 08:16:31 2017	(r327379)
> @@ -573,9 +573,10 @@ isa_probe_children(device_t dev)
>  
>  		err = device_probe_and_attach(child);
>  		if (err == 0 && idev->id_vendorid == 0 &&
> -		    strcmp(kern_ident, "GENERIC") == 0)
> +		    strcmp(kern_ident, "GENERIC") == 0 &&
> +		    device_is_attached(child))
>  			device_printf(child,
> -			    "non-PNP ISA device will be removed from GENERIC in FreeBSD 12.");
> +			    "non-PNP ISA device will be removed from GENERIC in FreeBSD 12.\n");

Hat:  RE

Do you plan to give this notice in 11.x?  (Technically a bit late,
it should of been in 11.0).

As giving it in 12.0 wont happen if you remove it in 12.  Ie, as you
have stated you want to remove this before we branch 12.0, if you do
that this notice well never be seen by the users.  Or well, they might
get the notice, but the drivers well have already been removed.

Or do you want to give notice in 12.* that it is being removed in 13.0.
And that is not supporting these for 10 years, as 12.x should be EOL
in a bit over 5 years from now if we cut in early 2018 which I believe
to be the current target.

>  	}
>  
>  	/*
> 
> 

-- 
Rod Grimes                                                 rgrimes at freebsd.org